[Seq-cvs-commit] SF.net SVN: seq:[1026] showeq/trunk/src/packetcapture.cpp

[<cn...@us...>]

Revision: 1026
          http://sourceforge.net/p/seq/svn/1026
Author:   cn187
Date:     2020-04-25 17:11:52 +0000 (Sat, 25 Apr 2020)
Log Message:
-----------
Fix packet decode delay with libpcap >= 1.9.1

Modified Paths:
--------------
    showeq/trunk/src/packetcapture.cpp

Modified: showeq/trunk/src/packetcapture.cpp
===================================================================
--- showeq/trunk/src/packetcapture.cpp	2020-04-25 17:10:38 UTC (rev 1025)
+++ showeq/trunk/src/packetcapture.cpp	2020-04-25 17:11:52 UTC (rev 1026)
@@ -136,8 +136,12 @@
      ** Not all  platforms  support  a read timeout; on platforms that
      ** don't, the read timeout is ignored.
      ** 
-     ** In Linux 2.4.x with the to_ms set to 0 we get packets immediatly,
-     ** and thats what we need in this application, so don't change it!! 
+     ** In Linux 2.4.x with the to_ms set to 0 we got packets immediatly,
+     ** and thats what we need in this application.  However, as of libpcap
+     ** 1.9.1, a timeout of 0 means infinity, so that no longer works. A
+     ** negative timeout will use the default kernal timeout, which can
+     ** vary.  So the most prudent option is to set the timeout as low
+     ** as we can, to 1 ms.
      ** 
      ** a race condition exists between this thread and the main thread 
      ** any artificial delay in getting packets can cause filtering problems
@@ -144,7 +148,7 @@
      ** and cause us to miss new stream when the player zones.
      */
     // initialize the pcap object 
-    m_pcache_pcap = pcap_open_live((char *) device, BUFSIZ, true, 0, ebuf);
+    m_pcache_pcap = pcap_open_live((char *) device, BUFSIZ, true, 1, ebuf);
 #ifdef __FreeBSD__
     // if we're on FreeBSD, we need to call ioctl on the file descriptor
     // with BIOCIMMEDIATE to get the kernel Berkeley Packet Filter device

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.