[Seq-cvs-commit] SF.net SVN: seq:[1014] showeq/branches/pre_6_0_beta/src/ spawnlistcommon.cpp

[<cn...@us...>]

Revision: 1014
          http://sourceforge.net/p/seq/svn/1014
Author:   cn187
Date:     2020-02-16 03:32:44 +0000 (Sun, 16 Feb 2020)
Log Message:
-----------
Fix spawnlist-related crashes due to bad pointer dereferences

Modified Paths:
--------------
    showeq/branches/pre_6_0_beta/src/spawnlistcommon.cpp

Modified: showeq/branches/pre_6_0_beta/src/spawnlistcommon.cpp
===================================================================
--- showeq/branches/pre_6_0_beta/src/spawnlistcommon.cpp	2020-02-15 16:05:15 UTC (rev 1013)
+++ showeq/branches/pre_6_0_beta/src/spawnlistcommon.cpp	2020-02-16 03:32:44 UTC (rev 1014)
@@ -134,7 +134,9 @@
   if (m_item == NULL)
      return -1;
 
-  SpawnListItem *other = (SpawnListItem *)i;
+  SpawnListItem *other = dynamic_cast<SpawnListItem *>(i);
+  if (other == NULL || other->m_item == NULL)
+     return 1;
 
   if (m_item->type() == tUnknown && other->m_item->type() == tUnknown)
      return 0;

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.