semanticscuttle-devel

Re: [Semanticscuttle-devel] Fix bugs, implement feature requests

[Christian W. <cw...@cw...>]

Hi Brett,


> I am new to open-source work and am currently familiarizing myself 
> with git and the product code. I think this will be primarily a 
> learning experience for me for a few weeks at least.

That's totally fine. There is no need to rush, and we have plenty of
small tasks you can do to get into the code. If you need help, just
send a mail to the mailing list or join me/us in #semanticscuttle on
freenode. If you have jabber/xmpp, you might add cw...@cw... to
your contact list.

Btw, the mailing list is on 
https://sourceforge.net/mailarchive/forum.php?forum_name=semanticscuttle-devel

You should at first get familiar with SemanticScuttle itself - download
it, install it and get it to work on your own machine.

Since you are very new, you might implement a small feature request:
> "Make default privacy configurable"
http://sourceforge.net/tracker/?func=detail&aid=3164348&group_id=211356&atid=1017433

The steps to take are:
1. Find out what the things are needed to do to implement the feature
2. Look at the code and see what needs to be done where to do it
3. Write that up and send it to the mailing list. We can discuss it then
4. Create your own feature branch (i.e. "configurable-privacy") from
   master and implement it in there
5. Push the branch to sourceforge so I can review it.
6. If everything is fine, I will merge it into the master branch

If you find out that that's not your thing, you could help at
other places, i.e. the documentation.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] Fix bugs, implement feature requests

[Mark P. <mpe...@gm...>]

Welcome aboard Brett.


On Fri, Jan 28, 2011 at 12:24 AM, Christian Weiske <cw...@cw...>wrote:

> Hi Brett,
>
>
> > I am new to open-source work and am currently familiarizing myself
> > with git and the product code. I think this will be primarily a
> > learning experience for me for a few weeks at least.
>
> That's totally fine. There is no need to rush, and we have plenty of
> small tasks you can do to get into the code. If you need help, just
> send a mail to the mailing list or join me/us in #semanticscuttle on
> freenode. If you have jabber/xmpp, you might add cw...@cw... to
> your contact list.
>
> Btw, the mailing list is on
>
> https://sourceforge.net/mailarchive/forum.php?forum_name=semanticscuttle-devel
>
> You should at first get familiar with SemanticScuttle itself - download
> it, install it and get it to work on your own machine.
>
> Since you are very new, you might implement a small feature request:
> > "Make default privacy configurable"
>
> http://sourceforge.net/tracker/?func=detail&aid=3164348&group_id=211356&atid=1017433
>
> The steps to take are:
> 1. Find out what the things are needed to do to implement the feature
> 2. Look at the code and see what needs to be done where to do it
> 3. Write that up and send it to the mailing list. We can discuss it then
> 4. Create your own feature branch (i.e. "configurable-privacy") from
>   master and implement it in there
> 5. Push the branch to sourceforge so I can review it.
> 6. If everything is fine, I will merge it into the master branch
>
> If you find out that that's not your thing, you could help at
> other places, i.e. the documentation.
>
> --
> Regards/Mit freundlichen Grüßen
> Christian Weiske
>
> -=≡ Geeking around in the name of science since 1982 ≡=-
>
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Semanticscuttle-devel mailing list
> Sem...@li...
> https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel
>
>

Re: [Semanticscuttle-devel] Fix bugs, implement feature requests

[Brett D. <bs...@fr...>]

Thanks.

On Fri, 28 Jan 2011 01:26:20 -0500, Mark Pemberton
<mpe...@gm...> wrote:
> Welcome aboard Brett.
> 
> On Fri, Jan 28, 2011 at 12:24 AM, Christian Weiske  wrote:
>  Hi Brett,
> 
>  > I am new to open-source work and am currently familiarizing myself
>  > with git and the product code. I think this will be primarily a
>  > learning experience for me for a few weeks at least.
> 
>  That's totally fine. There is no need to rush, and we have plenty of
>  small tasks you can do to get into the code. If you need help, just
>  send a mail to the mailing list or join me/us in #semanticscuttle on
>  freenode. If you have jabber/xmpp, you might add cw...@cw...
> [2] to
>  your contact list.
> 
>  Btw, the mailing list is on
> 
> https://sourceforge.net/mailarchive/forum.php?forum_name=semanticscuttle-devel
> [3]
> 
>  You should at first get familiar with SemanticScuttle itself -
> download
>  it, install it and get it to work on your own machine.
> 
>  Since you are very new, you might implement a small feature request:
>  > "Make default privacy configurable"
> 
> http://sourceforge.net/tracker/?func=detail&aid=3164348&group_id=211356&atid=1017433
> [4]
> 
>  The steps to take are:
>  1. Find out what the things are needed to do to implement the
> feature
>  2. Look at the code and see what needs to be done where to do it
>  3. Write that up and send it to the mailing list. We can discuss it
> then
>  4. Create your own feature branch (i.e. "configurable-privacy") from
>    master and implement it in there
>  5. Push the branch to sourceforge so I can review it.
>  6. If everything is fine, I will merge it into the master branch
> 
>  If you find out that that's not your thing, you could help at
>  other places, i.e. the documentation.
> 
>  --
>  Regards/Mit freundlichen Grüßen
>  Christian Weiske
> 
>  -=≡ Geeking around in the name of science since 1982 ≡=-
> 
> ------------------------------------------------------------------------------
>  Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
>  Finally, a world-class log management solution at an even better
> price-free!
>  Download using promo code Free_Logger_4_Dev2Dev. Offer expires
>  February 28th, so secure your free ArcSight Logger TODAY!
>  http://p.sf.net/sfu/arcsight-sfd2d [5]
> _______________________________________________
>  Semanticscuttle-devel mailing list
>  Sem...@li... [6]
>  https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel
> [7]
> 
> 
> 
> Links:
> ------
> [1] mailto:cw...@cw...
> [2] mailto:cw...@cw...
> [3]
> https://sourceforge.net/mailarchive/forum.php?forum_name=semanticscuttle-devel
> [4]
> http://sourceforge.net/tracker/?func=detail&aid=3164348&group_id=211356&atid=1017433
> [5] http://p.sf.net/sfu/arcsight-sfd2d
> [6] mailto:Sem...@li...
> [7]
> https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel

[Semanticscuttle-devel] Feature request #3164348: Make default privacy configurable

[Brett D. <bs...@fr...>]

Hi all,

This is in regards to feature request #3164348
[http://sourceforge.net/tracker/?func=detail&aid=3164348&group_id=211356&atid=1017433],
"Make default privacy configurable."

Privacy can be made configurable when the bookmark is added by the
modifications described in the feature request, but the assignment to
'bStatus' is also made 16 lines before in the preceding if block. In the
event that POST_TAGS is not set, an array is created with a default
bStatus value of 0. I think this should also be set to the global
default:

'tags' => (POST_TAGS ? explode(',', stripslashes(POST_TAGS)) :
array()),
                'bStatus' => $GLOBALS['privacy_default'], //New
assignment.
		//'bStatus' => 0, //Old assignment.
           );

Let me know if you have other suggestions/thoughts.

Thanks and Regards,
Brett


On Fri, 28 Jan 2011 06:24:20 +0100, Christian Weiske
<cw...@cw...> wrote:
> Hi Brett,
> 
> 
>> I am new to open-source work and am currently familiarizing myself
>> with git and the product code. I think this will be primarily a
>> learning experience for me for a few weeks at least.
> 
> That's totally fine. There is no need to rush, and we have plenty of
> small tasks you can do to get into the code. If you need help, just
> send a mail to the mailing list or join me/us in #semanticscuttle on
> freenode. If you have jabber/xmpp, you might add cw...@cw... to
> your contact list.
> 
> Btw, the mailing list is on 
> https://sourceforge.net/mailarchive/forum.php?forum_name=semanticscuttle-devel
> 
> You should at first get familiar with SemanticScuttle itself - download
> it, install it and get it to work on your own machine.
> 
> Since you are very new, you might implement a small feature request:
>> "Make default privacy configurable"
> http://sourceforge.net/tracker/?func=detail&aid=3164348&group_id=211356&atid=1017433
> 
> The steps to take are:
> 1. Find out what the things are needed to do to implement the feature
> 2. Look at the code and see what needs to be done where to do it
> 3. Write that up and send it to the mailing list. We can discuss it then
> 4. Create your own feature branch (i.e. "configurable-privacy") from
>    master and implement it in there
> 5. Push the branch to sourceforge so I can review it.
> 6. If everything is fine, I will merge it into the master branch
> 
> If you find out that that's not your thing, you could help at
> other places, i.e. the documentation.

Re: [Semanticscuttle-devel] Feature request #3164348: Make default privacy configurable

[Christian W. <cw...@cw...>]

Hi Brett,


> This is in regards to feature request #3164348
> [http://sourceforge.net/tracker/?func=detail&aid=3164348&group_id=211356&atid=1017433],
> "Make default privacy configurable."
> 
> Privacy can be made configurable when the bookmark is added by the
> modifications described in the feature request, but the assignment to
> 'bStatus' is also made 16 lines before in the preceding if block. In
> the event that POST_TAGS is not set, an array is created with a
> default bStatus value of 0. I think this should also be set to the
> global default:
The idea is correct, but you missed some points where bookmarks are
added/updated:
- www/bookmarks.php (what you probably meant)
- www/edit.php
- www/api/posts_add.php

All of them need to be modified, and you will need to add unit tests to
verify it works.


> 'tags' => (POST_TAGS ? explode(',', stripslashes(POST_TAGS)) :
> array()),
>                 'bStatus' => $GLOBALS['privacy_default'], //New
> assignment.
> 		//'bStatus' => 0, //Old assignment.
>            );
We need to structure the settings a bit, so I'd call the variable
> $GLOBALS['defaults']['privacy']
You should add it to the config.defaults.php, too.

I'd say go on and implement it in a new feature branch, i.e.
configurable-privacy.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] Feature request #3164348: Make default privacy configurable

[Christian W. <cw...@cw...>]

Hi again,


> The idea is correct, but you missed some points where bookmarks are
> added/updated:
> - www/bookmarks.php (what you probably meant)
> - www/edit.php
> - www/api/posts_add.php
I also missed some points, i.e. the import scripts. Just grep/ack-grep
the files.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] Feature request #3164348: Make default privacy configurable

[Brett D. <bs...@fr...>]

Thanks for the clarifications. I will do a more thorough recursive
grep.

I will also need to learn more about the unit testing tool.

Rgrds,
Brett

On Wed, 9 Feb 2011 07:20:33 +0100, Christian Weiske
<cw...@cw...> wrote:
> Hi again,
> 
> 
>> The idea is correct, but you missed some points where bookmarks are
>> added/updated:
>> - www/bookmarks.php (what you probably meant)
>> - www/edit.php
>> - www/api/posts_add.php
> I also missed some points, i.e. the import scripts. Just grep/ack-grep
> the files.

Re: [Semanticscuttle-devel] Feature request #3164348: Make default privacy configurable

[Christian W. <cw...@cw...>]

Hi Brett,


> I will also need to learn more about the unit testing tool.

We use PHPUnit from www.phpunit.de
Running the tests is pretty easy:
$ cd tests
$ phpunit .


-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] Fix bugs, implement feature requests

[Brett D. <bs...@fr...>]

That sounds like a good place to start. I'm getting SemanticScuttle up
and running now.

Thanks.

Rgrds,
Brett


On Fri, 28 Jan 2011 06:24:20 +0100, Christian Weiske
<cw...@cw...> wrote:
> Hi Brett,
> 
> 
>> I am new to open-source work and am currently familiarizing myself
>> with git and the product code. I think this will be primarily a
>> learning experience for me for a few weeks at least.
> 
> That's totally fine. There is no need to rush, and we have plenty of
> small tasks you can do to get into the code. If you need help, just
> send a mail to the mailing list or join me/us in #semanticscuttle on
> freenode. If you have jabber/xmpp, you might add cw...@cw... to
> your contact list.
> 
> Btw, the mailing list is on 
> https://sourceforge.net/mailarchive/forum.php?forum_name=semanticscuttle-devel
> 
> You should at first get familiar with SemanticScuttle itself - download
> it, install it and get it to work on your own machine.
> 
> Since you are very new, you might implement a small feature request:
>> "Make default privacy configurable"
> http://sourceforge.net/tracker/?func=detail&aid=3164348&group_id=211356&atid=1017433
> 
> The steps to take are:
> 1. Find out what the things are needed to do to implement the feature
> 2. Look at the code and see what needs to be done where to do it
> 3. Write that up and send it to the mailing list. We can discuss it then
> 4. Create your own feature branch (i.e. "configurable-privacy") from
>    master and implement it in there
> 5. Push the branch to sourceforge so I can review it.
> 6. If everything is fine, I will merge it into the master branch
> 
> If you find out that that's not your thing, you could help at
> other places, i.e. the documentation.