semanticscuttle-devel

Re: [Semanticscuttle-devel] Privatekey

[Christian W. <cw...@cw...>]

Hello Mark,


> > Generating new key throws away form changes. This isn't that nice,
> > but I'll accept it for now and we can fix that when the quickform
> > branch is finished.
> If quickform is not far off, then I agree.  I'm a bit agitated for
> missing this one, so if it needs to be corrected now, I'll be glad to
> do it.
I don't think that it's too far off - it's the next branch I'm working
on. Should be in 0.99 or 0.100.0


-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] Privatekey

[Christian W. <cw...@cw...>]

Hello Mark,


I merged the master branch into your privatekey branch so that it got
the latest API fixes and unittest helpers.
Your earlier whitespace changes made merging a tough job; I had to
manually resolve conflicts in about 15 files :/

After merging, tests did not run because automatic merge
apparently didn't work for the testbase class, but I fixed it and now
the unit tests do work again.

I did not do any manual browser tests yet, so things may be broken.
Merging was nevertheless necessary to ease merging into the master
branch once the privatekey feature is finished.


-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] Privatekey

[Christian W. <cw...@cw...>]

Hello Mark,


> > And just a heads-up, I tried to test everything regarding the
> > special characters with the titles, etc.  If you find something
> > that is not right, let me know.
> 
> + Privatekey works fine for the user's own bookmarks
> - Does not work with all bookmarks (plain rss.php?privatekey) - I'm
>   likely to subscribe to the all bookmarks feed in a private SC setup
>   with a several users.
> + Enabling and disabling the private key works fine
> + Error page when accessing feed with wrong private key
> + Error page when accessing feed with disabled private key
> - Generating new key throws away form changes. This isn't that nice,
>   but I'll accept it for now and we can fix that when the quickform
>   branch is finished.
> - 1) BookmarkTest::testPrivateBookmarks
>   Undefined offset: 1
>   /home/cweiske/Dev/semanticscuttle/cwdev/tests/BookmarkTest.php:1387

What's the status of the open missing items?

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] Privatekey

[Mark P. <mpe...@gm...>]

> - Does not work with all bookmarks (plain rss.php?privatekey) - I'm
>   likely to subscribe to the all bookmarks feed in a private SC setup
>   with a several users.
Sorry for being a little slow, but I need a little clarification on this.  I
was using the passed username as well as the privatekey for authentication.
 So if the request is to simply have the plain rss.php?privatekey=123 url,
then I'll need to alter the authentication function.  Additionally, what
would the plain url show that would be different than the full url
(rss.php/mpemberton?privatekey=123)?

> - Generating new key throws away form changes. This isn't that nice,
>   but I'll accept it for now and we can fix that when the quickform
>   branch is finished.
We still good at waiting on this when the Quickform branch is done?

> - 1) BookmarkTest::testPrivateBookmarks
>   Undefined offset: 1
>   /home/cweiske/Dev/semanticscuttle/cwdev/tests/BookmarkTest.php:1387
Updated - just changed it to look at the size of the array versus an actual
array element.

Cheers,
Mark


On Fri, Apr 29, 2011 at 12:55 AM, Christian Weiske <cw...@cw...>wrote:

> Hello Mark,
>
>
> > > And just a heads-up, I tried to test everything regarding the
> > > special characters with the titles, etc.  If you find something
> > > that is not right, let me know.
> >
> > + Privatekey works fine for the user's own bookmarks
> > - Does not work with all bookmarks (plain rss.php?privatekey) - I'm
> >   likely to subscribe to the all bookmarks feed in a private SC setup
> >   with a several users.
> > + Enabling and disabling the private key works fine
> > + Error page when accessing feed with wrong private key
> > + Error page when accessing feed with disabled private key
> > - Generating new key throws away form changes. This isn't that nice,
> >   but I'll accept it for now and we can fix that when the quickform
> >   branch is finished.
> > - 1) BookmarkTest::testPrivateBookmarks
> >   Undefined offset: 1
> >   /home/cweiske/Dev/semanticscuttle/cwdev/tests/BookmarkTest.php:1387
>
> What's the status of the open missing items?
>
> --
> Regards/Mit freundlichen Grüßen
> Christian Weiske
>
> -=≡ Geeking around in the name of science since 1982 ≡=-
>
>
> ------------------------------------------------------------------------------
> WhatsUp Gold - Download Free Network Management Software
> The most intuitive, comprehensive, and cost-effective network
> management toolset available today.  Delivers lowest initial
> acquisition cost and overall TCO of any competing solution.
> http://p.sf.net/sfu/whatsupgold-sd
> _______________________________________________
> Semanticscuttle-devel mailing list
> Sem...@li...
> https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel
>
>

Re: [Semanticscuttle-devel] Privatekey

[Christian W. <cw...@cw...>]

Hello Mark,


> > - Does not work with all bookmarks (plain rss.php?privatekey) - I'm
> >   likely to subscribe to the all bookmarks feed in a private SC
> > setup with a several users.
> Sorry for being a little slow, but I need a little clarification on
> this.  I was using the passed username as well as the privatekey for
> authentication. So if the request is to simply have the plain
> rss.php?privatekey=123 url, then I'll need to alter the
> authentication function.  Additionally, what would the plain url show
> that would be different than the full url
> (rss.php/mpemberton?privatekey=123)?

rss.php/$username returns the user's bookmarks, while rss.php without
username returns bookmarks of all users - adding the privatekey would
also list new bookmarks that got shared with the current user
(watchlist+shared bookmark), and his private ones. Getting bookmarks
that are shared with me is important.

For authentication, the private key should be enough, since it's unique
within the database.


> > - Generating new key throws away form changes. This isn't that nice,
> >   but I'll accept it for now and we can fix that when the quickform
> >   branch is finished.
> We still good at waiting on this when the Quickform branch is done?
Yep.

> > - 1) BookmarkTest::testPrivateBookmarks
> >   Undefined offset: 1
> >   /home/cweiske/Dev/semanticscuttle/cwdev/tests/BookmarkTest.php:1387
> Updated - just changed it to look at the size of the array versus an
> actual array element.

That's fine.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] Privatekey

[Christian W. <cw...@cw...>]

Hello Mark,


> > - 1) BookmarkTest::testPrivateBookmarks
> >   Undefined offset: 1
> >   /home/cweiske/Dev/semanticscuttle/cwdev/tests/BookmarkTest.php:1387
> Updated - just changed it to look at the size of the array versus an
> actual array element.

You did it the wrong way:
> $this->assertEquals(count($bookmarks['bookmarks']),1);
In PHPUnit, you always specify the expected value first and the actual
value second. All assertion methods allow another optional parameter,
the additional error message to make errors clearer.

So instead of
> $this->assertEquals(234, $obj->some->property)
you can write
> $this->assertEquals(234, $obj->some->property, 'property should
> always be 234 - it is specified that way')

PHPUnit then will print out your error message plus the "normal"
"failed to assert that 434 equals 234". I use this for complicated
assertions that need an explanation. In your case, this is not needed.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-