semanticscuttle-devel — General discussion about SemanticScuttle development

Re: [Semanticscuttle-devel] Questions about SematicScuttle

[Christian W. <cw...@cw...>]

Hello Anthony,


>  1. Can an administrator manage and delete users?

No, SemanticScuttle has no user management.

>  2. How easy is it to disable online registrations?

Easy, it's a config option:

$enableRegistration = false;


>  3. Does Scuttle have an administration page for the website?

No. You do administration via the configuration file.

>  4. Is it mobile friendly and responsive?

The default theme is not responsive.

There is a theme on the themes list[1] which is responsive, though:
flat[2].


[1]
http://semanticscuttle.sourceforge.net/docs/themes.html#existing-themes
[2] https://github.com/rlehnhof/flat 

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

[Semanticscuttle-devel] Questions about SematicScuttle

[AA <acu...@ya...>]

Hello,

Scuttle is great software.
Been using the original software for a while now.
But now there are serious issues with it.
I wonder about upgrading to SematicScuttle.


  Questions about SematicScuttle

 1. Can an administrator manage and delete users?
 2. How easy is it to disable online registrations?
 3. Does Scuttle have an administration page for the website?
 4. Is it mobile friendly and responsive?

Thank you.

Anthony
@anthonyealvarez <https://twitter.com/AnthonyEAlvarez>

[Semanticscuttle-devel] (no subject)

[Rodrigo MR <roc...@gm...>]

hi

i need know the difference betwen semanticscuttle and scuttle

and where i can get the code of the firefox and chrome extensions

thanks

[Semanticscuttle-devel] SemanticScuttle 0.98.5 released

[Christian W. <cw...@cw...>]

Hello,


I've just released SemanticScuttle 0.98.5. It's a small bugfix release
with no new features:

- Fix bug #109: preserve privacy setting from Delicious export files
  (Thanks to David Glenck)
- Fix bug #110: Document solution for "searching slashes"
- Fix bug #111: Comments in config.php mention \*.inc.php files
  (José María Mateos [rinze])
- Fix bug: Do not use eregi functions anymore

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

[Semanticscuttle-devel] SemanticScuttle 0.98.4 released

[Christian W. <cw...@cw...>]

Hi,


SemanticScuttle in version 0.98.4 - a major bugfix release - is out.

The following issues have been resolved:

- Fix bug #3439729: URLs were escaped too often in bookmark list
- Fix bug: Subtitle was not escaped
- Fix bug #3388219: Incorrect URL when cancelling tag2tag-actions
- Fix bug #3393951: Logo images missing on bookmark page
- Fix bug #3399815: PHP error in opensearch API in 0.98.3
- Fix bug #3407728: Can't delete users from admin page
- Fix bug #3431742: open_basedir problems with /etc/ config files
- Fix bug #3436624: Wrong URL for Delicious API when importing
- Fix bug #3463481: RSS feed show warnings in feedvalidator.org
- Fix bug #3384416: Use URL with protocol in bookmarklet
- Fix bug: Invalid HTML when website thumbnails are activated
- Fix bug #3413459: Thumbnails not in one line
- Fix bug #3468293: Delicious import does not preserve private links
- Fix bug #3396727: Title of http://lesscss.org/ not loaded
- Fix bug #3111254: getIdFromUser() always returns an integer now (part
  2)
- Implement request #3403609: fr_CA translation update
- Implement patch #3476011: PostgreSQL tables can not be initialized
  (Frédéric Fauberteau [triaxx])

Get the file from
> https://sourceforge.net/projects/semanticscuttle/        

or upgrade via pear:

$ pear upgrade sc/semanticscuttle-beta

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

[Semanticscuttle-devel] SemanticScuttle / merged turkish translation

[Christian W. <cw...@cw...>]

Hello Yalcin,


I merged your turkish translation into master. Thanks for the work!

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

[Semanticscuttle-devel] SemanticScuttle 0.98.3 released

[Christian W. <cw...@cw...>]

Hi,


The script that to fix the system:unfiled bookmark tags was missing in
the .zip release of SemanticScuttle 0.98.2, so I had to make a new
version 0.98.3 which definitively contains it.

If you installed the PEAR package, you did get the script - no need to
upgrade (and there isn't a 0.98.3 PEAR package because of that).


Get the file from
> https://sourceforge.net/projects/semanticscuttle/      

Alternatively, you can get the script from 
http://semanticscuttle.git.sourceforge.net/git/gitweb.cgi?p=semanticscuttle/sc;a=blob;f=scripts/fix-unfiled-tags.php


-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

[Semanticscuttle-devel] SemanticScuttle 0.98.2 is there!

[Christian W. <cw...@cw...>]

Hello fellow bookmarkers,


Version 0.98.2 of SemanticScuttle is out.
It contains a handful of bugfixes users reported on 0.98.1:
- Fix bug #3385724: Rename tag ends with XML Parsing Error
- Fix bug #3386178: "system:unfiled" secret tag does not work
- Fix bug #3384416: Update documentation to explain HTTP/HTTPS root
  problem
- Fix bug #3382126: Linked tags does not work for tags with spaces
- Fix delicious API help page link

Run ``scripts/fix-unfiled-tags.php`` to fix old bookmarks that miss the
``system:unfiled`` tags.


Get the files from
> https://sourceforge.net/projects/semanticscuttle/    

or upgrade via pear:
$ pear upgrade sc/semanticscuttle-beta

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

[Semanticscuttle-devel] SemanticScuttle 0.98.1 released!

[Christian W. <cw...@cw...>]

Hi all,


Version 0.98.1 of SemanticScuttle has been released!
It contains a handful of bugfixes users reported on 0.98.0:

- Fix bug #3375635: XML parsing problem in top.inc.php
- Fix bug #3375428: Forgot to remove some old dojo files
- Fix bug #3160512: Make SemanticScuttle work with FastCGI
- Fix bug #3376618: Broken tag completion for private bookmarks

Get the files from
> https://sourceforge.net/projects/semanticscuttle/  

or upgrade via pear:
$ pear upgrade sc/semanticscuttle-beta

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] Reasons for SemanticScuttle fix for apache 1.3

[Christian W. <cw...@cw...>]

Hello Benjamin,


> I'm wondering about a commit you did in 2009-03-05 which breaks some
> systems. Do you remember the bug number or the reasons why you did
> that? Maybe have the old conversation with the user who needed that?

There is also the same problem with the commit from 2008-06-04 - it
breaks at least one CGI system. Knowing the circumstances for the fix
would help me isolating the problem.

Bug fix: correct problem with PATH_INFO (Thanks to Montie)

git-svn-id:
https://semanticscuttle.svn.sourceforge.net/svnroot/semanticscuttle/trunk@135
b3834d28-1941-0410-a4f8-b48e95affb8f

diff --git a/constants.inc.php b/constants.inc.php
index cadaffa..824561f 100644
@@ -16,4 +16,10 @@ define('PAGE_BOOKMARKS', "bookmarks");
 // INSTALLATION_ID is based on directory DB and used as prefix (in
session and cookie) to prevent mutual login for different installations
on the same host server define('INSTALLATION_ID',
md5($GLOBALS['dbname'].$GLOBALS['tableprefix']));
+
+// Correct bug with PATH_INFO (maybe for Apache 1)
+if(strlen($_SERVER["PATH_INFO"])<strlen($_SERVER["ORIG_PATH_INFO"])) {
+    $_SERVER["PATH_INFO"] = $_SERVER["ORIG_PATH_INFO"]; 
+}
+
 ?>


-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

[Semanticscuttle-devel] Reasons for SemanticScuttle fix for apache 1.3

[Christian W. <cw...@cw...>]

Hello Benjamin,


I'm wondering about a commit you did in 2009-03-05 which breaks some
systems. Do you remember the bug number or the reasons why you did
that? Maybe have the old conversation with the user who needed that?


Code is:

Bug fix: correct bug for APACHE 1.3

git-svn-id:
https://semanticscuttle.svn.sourceforge.net/svnroot/semanticscuttle/trunk@306
b3834d28-1941-0410-a4f8-b48e95affb8f

diff --git a/constants.inc.php b/constants.inc.php
index 681a141..c198165 100644
@@ -47,10 +47,14 @@ define('PAGE_WATCHLIST', "watchlist");
 // INSTALLATION_ID is based on directory DB and used as prefix (in
session and cookie) to prevent mutual login for different installations
on the same host server define('INSTALLATION_ID',
md5($GLOBALS['dbname'].$GLOBALS['tableprefix'])); -
-// Correct bug with PATH_INFO (maybe for Apache 1)
+// Correct bugs with PATH_INFO (maybe for Apache 1 or CGI) -- for 1&1
host...
if(strlen($_SERVER["PATH_INFO"])<strlen($_SERVER["ORIG_PATH_INFO"]))
{ $_SERVER["PATH_INFO"] = $_SERVER["ORIG_PATH_INFO"]; }
-
+if(strcasecmp($_SERVER["PATH_INFO"], $_SERVER["SCRIPT_NAME "]) == 0) {
+	unset($_SERVER["PATH_INFO"]);
+}
+if(strpos($_SERVER["PATH_INFO"], '.php') !== false) {
+	unset($_SERVER["PATH_INFO"]);
+}
 ?>


-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] SemanticScuttle 0.98.0 released!

[Christian W. <cw...@cw...>]

Hi all,

> I've just released version 0.98.0 of SemanticScuttle on sourceforge.
> Get it while it's hot from 
> > https://sourceforge.net/projects/semanticscuttle/

My blog entry covering the release
http://cweiske.de/tagebuch/semanticscuttle-0.98.htm

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

[Semanticscuttle-devel] SemanticScuttle 0.98.0 released!

[Christian W. <cw...@cw...>]

Hi all,


I've just released version 0.98.0 of SemanticScuttle on sourceforge.
Get it while it's hot from 
> https://sourceforge.net/projects/semanticscuttle/


The changelog is quite big this time:

- Switch to jQuery and drop dojo
- Implement request #2928950: Private keys for RSS feeds (Mark
  Pemberton)
- Implement request #3164348: Configurable default privacy (Brett Dee)
- Implement request #1989987: Theming support
- Implement request #3054906: Show user's full name instead of nickname
- Implement patch #3059829: update ``FR_CA`` translation
- Fix bug #3187177: Wrong URL / Export XML Bookmarks
- Fix bug #3097187: Using opensearch with two tags does not work in
  Firefox
- Fix bug #3251877: French translation JavaScript Bug when editing
  bookmarks
- Fix bug #3168521: Title of tag-filtered RSS Feed is broken
- Fix bug #2853627: Javascript warning
- Fix bug in ``getTagsForBookmarks()`` that fetched all tags
- Fix privacy issue when fetching tags of several users
- Fix Google custom search XML
- Show error message on mysqli connection errors
- Update php-gettext library to 1.0.10
- ``api/posts/add`` respects the "replace" parameter now
- Only URLs with an allowed protocol may be added to the database
- Support HTTPS connections when ``$root`` is not configured
- SQL schema version table to ease future database upgrades
- Documentation is written with rST (reStructuredText) now
- Support per-host configuration files

We've got documentation on the website now:
> http://semanticscuttle.sourceforge.net/docs/


-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

[Semanticscuttle-devel] Privatekey branch merged to master!

[Christian W. <cw...@cw...>]

Hi all,


The privatekey branch has been merged to master, and I deleted the
privatekey branch itself. We're nearly ready for 0.98 now.

Things left to do:
- Fix documentation generation, use new phing rSTTask I wrote (I'm
  doing that right now)
- Test the new version (we can all do that: Change the version in
  build.xml and run "phing package". Then try to install the generated
  dist/*0.98.0.zip freshly, with a fresh database and try to do normal
  things there - setup, user registration, login, adding bookmarks etc.
- If all is fine, 0.98.0 gets out.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] Last tests / Chat with Christian Weiske

[Christian W. <cw...@cw...>]

Hello Mark,


> > 12:10 PM Christian: i'll implement the missing privatekey tests now
> >   except you have written them already and didn't push them :)
> I pushed my last set of updates on the 15th.  Look for rssTest.php in
> www folder.  Let me know if there is something else you are looking
> for.

I simplified the tests quite a bit and added the missing "check if
still logged in" test. I'll look through the mails again to see if
there is something missing, but the tests look ok now.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

[Semanticscuttle-devel] Back in a week

[Christian W. <cw...@cw...>]

Hi Brett and Mark,


I'll be away for vacation for a week.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] getBookmarks() tag problems / user session problems

[Christian W. <cw...@cw...>]

Hello Mark,


> Cut/Paste burns me again.  I had it right initially, but cut/pasted
> another line and failed to fix the argument.  Fixed.  Wonder if that
> would be worthy of another unit test...  :)
Definitely. We've been talking about that special problem for weeks.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] getBookmarks() tag problems / user session problems

[Mark P. <mpe...@gm...>]

Cut/Paste burns me again.  I had it right initially, but cut/pasted
another line and failed to fix the argument.  Fixed.  Wonder if that
would be worthy of another unit test...  :)

Cheers,
Mark

On Wed, Jun 15, 2011 at 8:27 AM, Christian Weiske <cw...@cw...> wrote:
> Hello Mark,
>
>
>> I've fixed the code and added a couple simplistic tests.
> You are setting the current user id now:
>> $this->setCurrentUserId($row[$this->getFieldName('primary')], true);
>
> But unfortunately, the ID gets set permanently:
>> public function setCurrentUserId($user, $storeInSession = false)
>
>
> --
> Regards/Mit freundlichen Grüßen
> Christian Weiske
>
> -=≡ Geeking around in the name of science since 1982 ≡=-
>
> ------------------------------------------------------------------------------
> EditLive Enterprise is the world's most technically advanced content
> authoring tool. Experience the power of Track Changes, Inline Image
> Editing and ensure content is compliant with Accessibility Checking.
> http://p.sf.net/sfu/ephox-dev2dev
> _______________________________________________
> Semanticscuttle-devel mailing list
> Sem...@li...
> https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel
>
>

Re: [Semanticscuttle-devel] getBookmarks() tag problems / user session problems

[Christian W. <cw...@cw...>]

Hello Mark,


> I've fixed the code and added a couple simplistic tests.
You are setting the current user id now:
> $this->setCurrentUserId($row[$this->getFieldName('primary')], true);

But unfortunately, the ID gets set permanently:
> public function setCurrentUserId($user, $storeInSession = false)


-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] getBookmarks() tag problems / user session problems

[Mark P. <mpe...@gm...>]

Hey Christian,

I've fixed the code and added a couple simplistic tests.  I can expand
the tests more this weekend, but wanted to live up to my promise of
getting something for you tonight.  Thanks for your patience pal.

Cheers,
Mark

On Thu, Jun 9, 2011 at 2:44 AM, Christian Weiske <cw...@cw...> wrote:
> Hello Mark,
>
>
>> I think I've added what you
>> requested, so let me know if you see anything else.
> I did a final code review and noticed that the core functionality of
> private keys - getting to see protected and private bookmarks in a
> feed - does not work. Apart from that, everything is looking really
> fine now.
>
> The reason is that in your latest commit, you removed the code that set
> the current user ID in Service_User::loginPrivateKey, so nobody knows
> that the user has been authenticated.
>
> Also nobody caught that because there are no unit tests for it :)
> Please add them the same way you did to check if the rss links are
> there (fetch URL and inspect the rss xml to see if the private and
> protected (watchlist) links are in there. Also do verify that private
> bookmarks of different users are not visible.
>
> --
> Regards/Mit freundlichen Grüßen
> Christian Weiske
>
> -=≡ Geeking around in the name of science since 1982 ≡=-
>
> ------------------------------------------------------------------------------
> EditLive Enterprise is the world's most technically advanced content
> authoring tool. Experience the power of Track Changes, Inline Image
> Editing and ensure content is compliant with Accessibility Checking.
> http://p.sf.net/sfu/ephox-dev2dev
> _______________________________________________
> Semanticscuttle-devel mailing list
> Sem...@li...
> https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel
>
>

Re: [Semanticscuttle-devel] getBookmarks() tag problems / user session problems

[Christian W. <cw...@cw...>]

Hello Mark,


> I think I've added what you
> requested, so let me know if you see anything else.
I did a final code review and noticed that the core functionality of
private keys - getting to see protected and private bookmarks in a
feed - does not work. Apart from that, everything is looking really
fine now.

The reason is that in your latest commit, you removed the code that set
the current user ID in Service_User::loginPrivateKey, so nobody knows
that the user has been authenticated.

Also nobody caught that because there are no unit tests for it :)
Please add them the same way you did to check if the rss links are
there (fetch URL and inspect the rss xml to see if the private and
protected (watchlist) links are in there. Also do verify that private
bookmarks of different users are not visible.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] getBookmarks() tag problems / user session problems

[Christian W. <cw...@cw...>]

Hello Mark,


> > I didn't do anything on SemanticScuttle the last week, but didn't
> > forget you. I began reading Winnetou I and am at the end of Winnetou
> > II  :)
> Interesting.  I've never heard of the book, but it's obviously a very
> popular series (selling over 200 million copies).  I may head down to
> our local used book store to see if they have it.  And not that it
> means much, but I'm like a fraction of Cherokee Indian.  For that
> matter, I also have some German heritage too... :)

Karl May, the German, is very popular here. The Winnetou indian novels
are entertaining to read - even though Karl May never has been in the
USA - and I lately asked myself why I didn't read the books when I was
a child. Since it's never too late to catch up on books, I got them
from Project Gutenberg as epub files for my nook ebook reader and am
entertained by them, even if Karl May really exaggerates here and
there :)


> > One test fails for me; it's
> > 1) www_bookmarksTest::testVerifyPrivateRSSLinkExists
> > Number of Links in Head not correct

I solved the problem: You missed a the unittestmode URL parameter.
Since I configured my SemanticScuttle to use a different database for
unit tests, the SemanticScuttle in non-unittestmode behaves differently
than in unit test mode because the data set is differently.
Now I just see that this feature is not really documented :/

Create a file
> data/config.testing.php
and put a different database in it:
> $dbname = 'semanticscuttle_tests';



> I've updated the xpath and did some additional checking.  Forgive my
> inexperience with xpath.  Still on a learning curve with it.  I'm
> loving it though!  I've also added a file for index.php.
Great.


> > I'm also not fully happy with the duplicated code in rss.php (the
> > privatekey login and check if that didn't work), but could live
> > with it for now.
> I've looked this code over quite a bit and I could pull a couple lines
> of code out to remove some of the duplication, but I think that whole
> if/else section may need to be completely reworked and I don't feel
> comfortable (yet) to do that.  Let's get this revision out and then we
> can rework it.
Yep.


> > Btw, how did you fix the time-problematic unit tests now? Do they
> > run for you now?
> After reverting back to gmdate(), I think there are only two changes
> that was necessary.  And yes, they run perfectly for me.  Please
> verify that I've done the right thing.
> 1) In tests/Bookmark2TagTest.php, in testGetPopularTagsDays(), the use
> of "today" doesn't return time (defaults to 00:00:00 AM) so I changed
> it to now which does.
> 2) In Service/Bookmark2Tag.php in getPopularTags(), there was a date()
> call that was never migrated over to use gmdate().
Great. 2 more bugs fixed :)


> > In www/index.php
> >> filter($sitename . sprintf(T_(': Recent bookmarks (private)')) .
> >> $currentUsername),
> > make the full string translatable, including the user name:
> >> T_(': Recent bookmarks (private) %s')
> > (there was a space missing after the ) btw)
> > and give the user name to sprintf as parameter - the sprintf was
> > totally useless since there were no placeholders in the string.
> Updated.  Please review to make sure it is ok.

Looks good.


-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Re: [Semanticscuttle-devel] getBookmarks() tag problems / user session problems

[Mark P. <mpe...@gm...>]

Hey Christian,

On Tue, Jun 7, 2011 at 3:08 PM, Christian Weiske <cw...@cw...> wrote:
> Hello Mark,
>
>
>> Didn't get a reply from my previous e-mail, so I went ahead and made
>> the assumption to #6 and everything else should be ok.  Forgive me on
>> my poor response, just been crazy after vacation.
> I didn't do anything on SemanticScuttle the last week, but didn't
> forget you. I began reading Winnetou I and am at the end of Winnetou
> II  :)
Interesting.  I've never heard of the book, but it's obviously a very
popular series (selling over 200 million copies).  I may head down to
our local used book store to see if they have it.  And not that it
means much, but I'm like a fraction of Cherokee Indian.  For that
matter, I also have some German heritage too... :)

>
>> Also, historically
>> I've not done much unit testing, but as I'm learning through this the
>> unit testing can prove quite valuable.
> One test fails for me; it's
>
> 1) www_bookmarksTest::testVerifyPrivateRSSLinkExists
> Number of Links in Head not correct
> Failed asserting that <integer:4> matches expected <integer:5>.
> /home/cweiske/Dev/semanticscuttle/cwdev/tests/www/bookmarksTest.php:102
>
> Btw, just checking for a number of links in the head isn't the best
> option. Add some xpath to count the rss links only.
> Instead of
>> '//ns:link'
> use something like
>> '//ns:link[@rel="alternate" and @type="application/rss+xml"]'
I've updated the xpath and did some additional checking.  Forgive my
inexperience with xpath.  Still on a learning curve with it.  I'm
loving it though!  I've also added a file for index.php.

>
> Did you also add negative tests? i.e. no private feed links when the
> user doesn't have a private key or he isn't logged in? (didn't look yet)
I didn't, but I have now.

>
> I'm also not fully happy with the duplicated code in rss.php (the
> privatekey login and check if that didn't work), but could live with it
> for now.
I've looked this code over quite a bit and I could pull a couple lines
of code out to remove some of the duplication, but I think that whole
if/else section may need to be completely reworked and I don't feel
comfortable (yet) to do that.  Let's get this revision out and then we
can rework it.

>
>
>> I think I've added what you
>> requested, so let me know if you see anything else.  I'm a bit of a
>> novice on xpath but was able put it together.
>>
>> I've also merged with master.  :)
> Seems the merge didn't fully work; the rss icon on the pager doesn't
> work anymore since it tries to use the old images/rss.gif location.
> Don't worry, that happens to the best :)
Fixed!  Duh!  :)

>
>
> Btw, how did you fix the time-problematic unit tests now? Do they run
> for you now?
After reverting back to gmdate(), I think there are only two changes
that was necessary.  And yes, they run perfectly for me.  Please
verify that I've done the right thing.
1) In tests/Bookmark2TagTest.php, in testGetPopularTagsDays(), the use
of "today" doesn't return time (defaults to 00:00:00 AM) so I changed
it to now which does.
2) In Service/Bookmark2Tag.php in getPopularTags(), there was a date()
call that was never migrated over to use gmdate().

>
> Oh, and I'd like to see smaller commits. For example, the reversion of
> the gmdate changes should be a single commit.
Understood.  I completely understand the usability of smaller commits.

>
>
> In www/index.php
>> filter($sitename . sprintf(T_(': Recent bookmarks (private)')) .
>> $currentUsername),
> make the full string translatable, including the user name:
>> T_(': Recent bookmarks (private) %s')
> (there was a space missing after the ) btw)
> and give the user name to sprintf as parameter - the sprintf was
> totally useless since there were no placeholders in the string.
Updated.  Please review to make sure it is ok.

Cheers,
Mark

>
> --
> Regards/Mit freundlichen Grüßen
> Christian Weiske
>
> -=≡ Geeking around in the name of science since 1982 ≡=-
>
> ------------------------------------------------------------------------------
> EditLive Enterprise is the world's most technically advanced content
> authoring tool. Experience the power of Track Changes, Inline Image
> Editing and ensure content is compliant with Accessibility Checking.
> http://p.sf.net/sfu/ephox-dev2dev
> _______________________________________________
> Semanticscuttle-devel mailing list
> Sem...@li...
> https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel
>
>

Re: [Semanticscuttle-devel] Next tasks for SemanticScuttle (0.99)

[Brett D. <bs...@fr...>]

Hello, Christian.

Sounds good. I'll start looking into it.

Rgrds,
Brett

On Tue, 7 Jun 2011 21:24:32 +0200, Christian Weiske
<cw...@cw...> wrote:
> Hello Brett,
> 
> 
>> I have nothing specific planned. Since I'm still relatively new to
>> this product, maybe you can point me to an appropriate feature.
> 
> You could add Atom support:
> https://sourceforge.net/tracker/?func=detail&aid=3311003&group_id=211356&atid=1017433
> 
> In essence, you need to add a new template file and make rss.php use
> the new template. You need to change the content type, too.
> Use feed-validator.org to verify that the feed is correct. Also add
> some tests if there are none yet. I think we should keep rss.php as
> file in the URL, even if we deliver Atom now.

Re: [Semanticscuttle-devel] Next tasks for SemanticScuttle (0.99)

[Christian W. <cw...@cw...>]

Hello Brett,


> I have nothing specific planned. Since I'm still relatively new to
> this product, maybe you can point me to an appropriate feature.

You could add Atom support:
https://sourceforge.net/tracker/?func=detail&aid=3311003&group_id=211356&atid=1017433

In essence, you need to add a new template file and make rss.php use
the new template. You need to change the content type, too.
Use feed-validator.org to verify that the feed is correct. Also add
some tests if there are none yet. I think we should keep rss.php as
file in the URL, even if we deliver Atom now.


-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-