Re: [Semanticscuttle-devel] getBookmarks() tag problems / user session problems

[Mark P. <mpe...@gm...>]

Hey Christian,

I've fixed the code and added a couple simplistic tests.  I can expand
the tests more this weekend, but wanted to live up to my promise of
getting something for you tonight.  Thanks for your patience pal.

Cheers,
Mark

On Thu, Jun 9, 2011 at 2:44 AM, Christian Weiske <cw...@cw...> wrote:
> Hello Mark,
>
>
>> I think I've added what you
>> requested, so let me know if you see anything else.
> I did a final code review and noticed that the core functionality of
> private keys - getting to see protected and private bookmarks in a
> feed - does not work. Apart from that, everything is looking really
> fine now.
>
> The reason is that in your latest commit, you removed the code that set
> the current user ID in Service_User::loginPrivateKey, so nobody knows
> that the user has been authenticated.
>
> Also nobody caught that because there are no unit tests for it :)
> Please add them the same way you did to check if the rss links are
> there (fetch URL and inspect the rss xml to see if the private and
> protected (watchlist) links are in there. Also do verify that private
> bookmarks of different users are not visible.
>
> --
> Regards/Mit freundlichen Grüßen
> Christian Weiske
>
> -=≡ Geeking around in the name of science since 1982 ≡=-
>
> ------------------------------------------------------------------------------
> EditLive Enterprise is the world's most technically advanced content
> authoring tool. Experience the power of Track Changes, Inline Image
> Editing and ensure content is compliant with Accessibility Checking.
> http://p.sf.net/sfu/ephox-dev2dev
> _______________________________________________
> Semanticscuttle-devel mailing list
> Sem...@li...
> https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel
>
>