Re: [Semanticscuttle-devel] getBookmarks() tag problems / user session problems

[Christian W. <cw...@cw...>]

Hello Mark,


> I think I've added what you
> requested, so let me know if you see anything else.
I did a final code review and noticed that the core functionality of
private keys - getting to see protected and private bookmarks in a
feed - does not work. Apart from that, everything is looking really
fine now.

The reason is that in your latest commit, you removed the code that set
the current user ID in Service_User::loginPrivateKey, so nobody knows
that the user has been authenticated.

Also nobody caught that because there are no unit tests for it :)
Please add them the same way you did to check if the rss links are
there (fetch URL and inspect the rss xml to see if the private and
protected (watchlist) links are in there. Also do verify that private
bookmarks of different users are not visible.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-