Re: [Semanticscuttle-devel] getBookmarks() tag problems / user session problems
Brought to you by:
cweiske
From: Mark P. <mpe...@gm...> - 2011-05-18 13:54:24
|
Just figured why we're not on the same page. I'm thinking the use of multiple tags is an inclusive search (i.e. give me bookmarks that have a tag "cat" or "dog") whereas you are wanting it to be an exclusive search (i.e. give me bookmarks that have both "cat" and "dog" as tags). I'll change getBookmarks() back to the way it was. On a side note, I don't see the need in this case to have multiple joins to the same table when multiple tags are searched. But since the original code seems to work well, I'm not going to change it. :) On Wed, May 18, 2011 at 1:58 AM, Christian Weiske <cw...@cw...> wrote: > Hello Mark, > > > >> in my understanding of how the tag2tag's work. The change I made >> seems to make sense, and seemed to produce the results that I was >> expecting. However, when I saw this test fail, red flags started >> raising and now my change is in doubt. So either the update to >> getBookmarks() is all wrong and all of it needs to be rejected, or it >> is right and the test needs to be updated. Regardless if I'm right or >> wrong, I'd love to use this opportunity to properly document this area >> of work to help eliminate confusion in the future. > > Your change to getBookmarks related to tags > (920f7fc623ecad4f1338ab68326f2817c12c4610) does not take into account > that several tags may be found. You're always checking on tag table 0 > and don't add any other tag table joins. If the first tag matches, the > second obviously cannot match, which is why it fails. > > > -- > Regards/Mit freundlichen Grüßen > Christian Weiske > > -=≡ Geeking around in the name of science since 1982 ≡=- > > ------------------------------------------------------------------------------ > What Every C/C++ and Fortran developer Should Know! > Read this article and learn how Intel has extended the reach of its > next-generation tools to help Windows* and Linux* C/C++ and Fortran > developers boost performance applications - including clusters. > http://p.sf.net/sfu/intel-dev2devmay > _______________________________________________ > Semanticscuttle-devel mailing list > Sem...@li... > https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel > > |