Re: [Semanticscuttle-devel] getBookmarks() tag problems / user session problems
Brought to you by:
cweiske
From: Christian W. <cw...@cw...> - 2011-05-18 06:22:29
|
Hello Mark, > in my understanding of how the tag2tag's work. The change I made > seems to make sense, and seemed to produce the results that I was > expecting. However, when I saw this test fail, red flags started > raising and now my change is in doubt. So either the update to > getBookmarks() is all wrong and all of it needs to be rejected, or it > is right and the test needs to be updated. Regardless if I'm right or > wrong, I'd love to use this opportunity to properly document this area > of work to help eliminate confusion in the future. Your change to getBookmarks related to tags (920f7fc623ecad4f1338ab68326f2817c12c4610) does not take into account that several tags may be found. You're always checking on tag table 0 and don't add any other tag table joins. If the first tag matches, the second obviously cannot match, which is why it fails. -- Regards/Mit freundlichen Grüßen Christian Weiske -=≡ Geeking around in the name of science since 1982 ≡=- |