Re: [Semanticscuttle-devel] user session problems
Brought to you by:
cweiske
From: Mark P. <mpe...@gm...> - 2011-05-17 05:18:19
|
Unit errors: 1a) One in Bookmark2TagTest::testGetPopularTagsDays appears to exist in master, so I can't claim that. I spent some time trying to resolve it, but was unable to. 1b) Another unresolved issue is in Tag2TagTest::testSearchThroughLinkedTags which is a result of a change I did in getBookmarks(). I'll go ahead and apologize now if I'm wrong in my understanding of how the tag2tag's work. The change I made seems to make sense, and seemed to produce the results that I was expecting. However, when I saw this test fail, red flags started raising and now my change is in doubt. So either the update to getBookmarks() is all wrong and all of it needs to be rejected, or it is right and the test needs to be updated. Regardless if I'm right or wrong, I'd love to use this opportunity to properly document this area of work to help eliminate confusion in the future. 1c) The rest of the unit errors are in the API and it appears to be my environment that is making them fail. I'll work on that later. If someone could confirm they still pass. 2) There are a couple duplicate lines and I've unfortunately not spent enough time reviewing how best to refine the duplication. 3) Updated code to use updated user session changes. 4) added privatekey support for tags. I wanted to go ahead and commit my changes because it'll be another day or two to review what additional unit tests need to be added/changed based on the above changes. Headed off to take a certification test tomorrow which has taken up lots of my time. Fun times. :) One thing outstanding that you mentioned is the desire to alter the ajax script to use JSON. I fully agree with you and the change needs to be made. However, because it is consistent with the other ajax calls, I hoping you'll allow me to make those changes after the 0.98.0 release. Cheers, Mark On Sat, May 14, 2011 at 7:21 PM, Mark Pemberton <mpe...@gm...> wrote: > Nope, you are 100% correct. I did edit the create-testbookmarks from 10 to > 10k when testing something and failed to return it to 10. The privatekey2 > has it back to 10. So rant accepted. :) > > On Sat, May 14, 2011 at 4:06 AM, Christian Weiske <cw...@cw...> > wrote: >> >> Hello Mark, >> >> >> > If this is the same list you are referring to, I thought we went >> > through all of them. >> I *thought* I mentioned that the create-testbookmarks script had a >> limit of 10k instead of 10 bookmarks in it, and that's what bothered >> me. But I looked through the mails and didn't find it. Consider my >> rant baseless. >> >> >> -- >> Regards/Mit freundlichen Grüßen >> Christian Weiske >> >> -=≡ Geeking around in the name of science since 1982 ≡=- >> >> >> ------------------------------------------------------------------------------ >> Achieve unprecedented app performance and reliability >> What every C/C++ and Fortran developer should know. >> Learn how Intel has extended the reach of its next-generation tools >> to help boost performance applications - inlcuding clusters. >> http://p.sf.net/sfu/intel-dev2devmay >> _______________________________________________ >> Semanticscuttle-devel mailing list >> Sem...@li... >> https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel >> > > |