Re: [Semanticscuttle-devel] user session problems

[Mark P. <mpe...@gm...>]

Status:  I've created the new branch from main, and just finished migrating
over all the privatekey changes.  About to head out of town

On Fri, May 13, 2011 at 8:50 AM, Mark Pemberton <mpe...@gm...>wrote:

> Here's the last list that I can find:
>    > + Privatekey works fine for the user's own bookmarks
> > - Does not work with all bookmarks (plain rss.php?privatekey) - I'm
> >   likely to subscribe to the all bookmarks feed in a private SC setup
> >   with a several users.
> > + Enabling and disabling the private key works fine
> > + Error page when accessing feed with wrong private key
> > + Error page when accessing feed with disabled private key
> > - Generating new key throws away form changes. This isn't that nice,
> >   but I'll accept it for now and we can fix that when the quickform
> >   branch is finished.
> > - 1) BookmarkTest::testPrivateBookmarks
> >   Undefined offset: 1
> >   /home/cweiske/Dev/semanticscuttle/cwdev/tests/BookmarkTest.php:1387
> If this is the same list you are referring to, I thought we went through
> all of them.  Will confess that I did see some unit test errors and will
> work on them.  I also had a lot of conflicts when merging master, which I
> thought was normal.
>
> No excuses on my part.  Here's a new working to-do list.  Please add as you
> see fit:
>
> Before continuing I'll create a new branch from master (calling it
> primarykey2) and pull in all relevant changes.
>
> 1) Resolve unit test errors
> 2) Refine code in rss.php
> 3) Update User.php::loginPrivateKey() to follow updated user session
> configuration
> 4) Add private key support to tag feeds
>
> Cheers,
> Mark
>
>
> On Fri, May 13, 2011 at 12:56 AM, Christian Weiske <cw...@cw...>wrote:
>
>> Hello Mark,
>>
>>
>> > Whew, ok, I either passed or failed.  Please check my work to make
>> > sure we're on the same page.  If I failed, don't be too harsh on me.
>> > Everything seems to be in order with the rss feed.
>>
>> Could you please look through the last QA list I sent? I just began
>> testing and many items are still open.
>>
>> I also saw that the opensearch unit test does not work because of a
>> leading empty line. Did it really work for you?
>>
>> And I'd like to have another feature, that is private key support for
>> tag feeds (add it to the meta there, too).
>>
>> About your latest changes:
>>
>> www/rss.php: You have 2 times the same privatekey code, which is
>> unnecessary in my eyes.
>> Service/User.php::loginprivatekey(): you set the session variable
>> instead of using setcurrentuserid.
>>
>>
>> I've got to say that I have problems comparing the privatekey branch
>> with master because of the many unrelated changes in there. The diff is
>> a whopping 214kiB. Since I don't want to throw that changes away and
>> lose your work, I'll gradually merge whitespace changes from your branch
>> into master.
>>
>> Maybe it would be helpful to start a new branch with a fresh clone of
>> the master branch and cherry-pick the relevant changes from the current
>> privatekey branch. This way we'd have a clean pk branch and overview
>> about all changes.
>>
>> --
>> Regards/Mit freundlichen Grüßen
>> Christian Weiske
>>
>> -=≡ Geeking around in the name of science since 1982 ≡=-
>>
>>
>> ------------------------------------------------------------------------------
>> Achieve unprecedented app performance and reliability
>> What every C/C++ and Fortran developer should know.
>> Learn how Intel has extended the reach of its next-generation tools
>> to help boost performance applications - inlcuding clusters.
>> http://p.sf.net/sfu/intel-dev2devmay
>> _______________________________________________
>> Semanticscuttle-devel mailing list
>> Sem...@li...
>> https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel
>>
>>
>