Re: [Semanticscuttle-devel] user session problems

[Christian W. <cw...@cw...>]

Hello Mark,


> Whew, ok, I either passed or failed.  Please check my work to make
> sure we're on the same page.  If I failed, don't be too harsh on me.
> Everything seems to be in order with the rss feed.

Could you please look through the last QA list I sent? I just began
testing and many items are still open.

I also saw that the opensearch unit test does not work because of a
leading empty line. Did it really work for you?

And I'd like to have another feature, that is private key support for
tag feeds (add it to the meta there, too).

About your latest changes:

www/rss.php: You have 2 times the same privatekey code, which is
unnecessary in my eyes. 
Service/User.php::loginprivatekey(): you set the session variable
instead of using setcurrentuserid.


I've got to say that I have problems comparing the privatekey branch
with master because of the many unrelated changes in there. The diff is
a whopping 214kiB. Since I don't want to throw that changes away and
lose your work, I'll gradually merge whitespace changes from your branch
into master.

Maybe it would be helpful to start a new branch with a fresh clone of
the master branch and cherry-pick the relevant changes from the current
privatekey branch. This way we'd have a clean pk branch and overview
about all changes.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-