Re: [Semanticscuttle-devel] SemanticScuttle 0.98.0 is near
Brought to you by:
cweiske
From: Mark P. <mpe...@gm...> - 2011-05-11 16:00:56
|
> I assume that getWatchNames uses the current user. Can't you just set > the current user without storing that information in the session? The call to getBookmarks() makes calls to getCurrentUserId() and isLoggedIn() which both require data stored in the session (via setCurrentUserId()). So if you want to avoid storing data in the session then we may need to add an additional argument to getBookmarks(). The getWatchNames() has two arguments (user ID, Watched By), so it makes no reference to the session/current user data. Throwing this out as an idea, I could pass the privatekey as an argument in getBookmarks() which will eliminate the need to store any data in the session. Thoughts? On Wed, May 11, 2011 at 11:15 AM, Christian Weiske <cw...@cw...>wrote: > Hi Mark, > > > > > When rss.php is called, > > 1) User is defined, no private key > > 2) User is defined, private key is defined and valid > > 3) User is not defined, no private key > > 4) User is not defined, private key is defined/valid > > > > Results: > > 1) All public bookmarks returned for specified user > > 2) All public bookmarks returned for specified user including any > > that are shared to watchlist (with privatekey user being on the watch > > list) 3) All public bookmarks > > 4) All public bookmarks including any shared to watchlist bookmarks > > where the privatekey user is on the watch list. > > > > (Please correct any assumptions I made above) > > > > #1 works fine, but the rest do not produce the correct results. One > > place I've pinpointed is the call in getBookmarks() where it calls > > getWatchNames(). The second argument is true which I believe should > > be false because we want the list of users that the passed user > > (argument 1) is watching. The other main change that will need to be > > made in getBookmarks() is the ability to distinguish these calls from > > rss.php where the user is authenticated via the privatekey but want > > all bookmarks (#3 and #4 above). > > I assume that getWatchNames uses the current user. Can't you just set > the current user without storing that information in the session? > > > > One last point which is unrelated is the "Watchlist" page, should > > that show the "shared" bookmarks of those users you are watching? It > > doesn't appear that it is now. > No, it shows the bookmarks of the users that have you added to their > watchlist. Actually the name "watchlist" is misleading, because it's a > "trust list". You trust those users on your watchlist to see your > protected bookmarks. > If you would see the protected bookmarks of the users on your > watchlist, you could easily see all protected bookmarks by adding all > users to your watchlist. > > > -- > Regards/Mit freundlichen Grüßen > Christian Weiske > > -= Geeking around in the name of science since 1982 =- > > > ------------------------------------------------------------------------------ > Achieve unprecedented app performance and reliability > What every C/C++ and Fortran developer should know. > Learn how Intel has extended the reach of its next-generation tools > to help boost performance applications - inlcuding clusters. > http://p.sf.net/sfu/intel-dev2devmay > _______________________________________________ > Semanticscuttle-devel mailing list > Sem...@li... > https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel > |