Re: [Semanticscuttle-devel] Privatekey

[Christian W. <cw...@cw...>]

Hello Mark,


> > - Does not work with all bookmarks (plain rss.php?privatekey) - I'm
> >   likely to subscribe to the all bookmarks feed in a private SC
> > setup with a several users.
> Sorry for being a little slow, but I need a little clarification on
> this.  I was using the passed username as well as the privatekey for
> authentication. So if the request is to simply have the plain
> rss.php?privatekey=123 url, then I'll need to alter the
> authentication function.  Additionally, what would the plain url show
> that would be different than the full url
> (rss.php/mpemberton?privatekey=123)?

rss.php/$username returns the user's bookmarks, while rss.php without
username returns bookmarks of all users - adding the privatekey would
also list new bookmarks that got shared with the current user
(watchlist+shared bookmark), and his private ones. Getting bookmarks
that are shared with me is important.

For authentication, the private key should be enough, since it's unique
within the database.


> > - Generating new key throws away form changes. This isn't that nice,
> >   but I'll accept it for now and we can fix that when the quickform
> >   branch is finished.
> We still good at waiting on this when the Quickform branch is done?
Yep.

> > - 1) BookmarkTest::testPrivateBookmarks
> >   Undefined offset: 1
> >   /home/cweiske/Dev/semanticscuttle/cwdev/tests/BookmarkTest.php:1387
> Updated - just changed it to look at the size of the array versus an
> actual array element.

That's fine.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-