Re: [Semanticscuttle-devel] Status for configurable privacy ....

[Brett D. <bs...@fr...>]

Hello, Christian.

I'll have a look at the unit tests this week. If I'm not able to clean
them up any more, I can at least learn from the changes you've made.

I am apprehensive about doing a merge myself since I am still
relatively new to git. However, I will need to learn this at some point
and will be installing msysgit soon.

Rgrds,
Brett

On Fri, 29 Apr 2011 06:59:36 +0200, Christian Weiske
<cw...@cw...> wrote:
> Hello Brett,
> 
> 
> You have probably noticed that I'm reworking some of your tests to be
> smaller and more independent, and replacing some of the test code with
> more abstract methods.
> 
> For example, you created a cookie yourself and relied on the knowledge
> how it is created internally. That is replaced with generic login
> method that does everything for you and gives you a http request full
> with all cookies needed. There were one or two bugs in that method
> which is why you probably didn't use it in the first place.
> 
> Only some of this things to fix are left, then we can merge master into
> your branch and - when all is fine - merge your branch into master.
> 
> I wrote some blog articles and had vacation last week which is why
> nothing happened on my side, but I'll probably get the last of your
> tests sorted out until next wednesday.
> 
> Brett, I'd be happy if you could continue making the tests nicer and
> merge master - but merging is not trivial if you don't have a good
> graphical mergetool or really know what you do. I can do that without
> problems.