Re: [Semanticscuttle-devel] Privatekey

[Mark P. <mpe...@gm...>]

> Does not work with all bookmarks (plain rss.php?privatekey) - I'm
> likely to subscribe to the all bookmarks feed in a private SC setup
> with a several users.
Totally missed this.  I bet unit testing would have caught it..... :(

> Generating new key throws away form changes. This isn't that nice,
> but I'll accept it for now and we can fix that when the quickform
> branch is finished.
If quickform is not far off, then I agree.  I'm a bit agitated for missing
this one, so if it needs to be corrected now, I'll be glad to do it.

> 1) BookmarkTest::testPrivateBookmarks
> Undefined offset: 1
> /home/cweiske/Dev/semanticscuttle/cwdev/tests/BookmarkTest.php:1387
Ok then I guess we can test the size of the array instead of the value.
 I'll replace it with this:
        $this->assertEquals(count($bookmarks['bookmarks']),1);




On Thu, Apr 7, 2011 at 4:57 PM, Christian Weiske <cw...@cw...> wrote:

> Hello Mark,
>
>
> > > Yep, made some final changes last night and didn't get a chance to
> > > commit. I just committed my work so please review.  Ok, I confess,
> > > I haven't done the below:
> > And just a heads-up, I tried to test everything regarding the special
> > characters with the titles, etc.  If you find something that is not
> > right, let me know.
>
> + Privatekey works fine for the user's own bookmarks
> - Does not work with all bookmarks (plain rss.php?privatekey) - I'm
>  likely to subscribe to the all bookmarks feed in a private SC setup
>  with a several users.
> + Enabling and disabling the private key works fine
> + Error page when accessing feed with wrong private key
> + Error page when accessing feed with disabled private key
> - Generating new key throws away form changes. This isn't that nice,
>  but I'll accept it for now and we can fix that when the quickform
>  branch is finished.
> - 1) BookmarkTest::testPrivateBookmarks
>  Undefined offset: 1
>  /home/cweiske/Dev/semanticscuttle/cwdev/tests/BookmarkTest.php:1387
>
> I did also run the unit tests with with coverage enabled and saw that
> i.e. "getUserByPrivateKey" is not tested. I'll help you with writing
> the tests.
>
> --
> Regards/Mit freundlichen Grüßen
> Christian Weiske
>
> -=≡ Geeking around in the name of science since 1982 ≡=-
>
>
> ------------------------------------------------------------------------------
> Xperia(TM) PLAY
> It's a major breakthrough. An authentic gaming
> smartphone on the nation's most reliable network.
> And it wants your games.
> http://p.sf.net/sfu/verizon-sfdev
> _______________________________________________
> Semanticscuttle-devel mailing list
> Sem...@li...
> https://lists.sourceforge.net/lists/listinfo/semanticscuttle-devel
>
>