Re: [Semanticscuttle-devel] Privatekey

[Christian W. <cw...@cw...>]

Hello Mark,


> > Yep, made some final changes last night and didn't get a chance to
> > commit. I just committed my work so please review.  Ok, I confess,
> > I haven't done the below:
> And just a heads-up, I tried to test everything regarding the special
> characters with the titles, etc.  If you find something that is not
> right, let me know.

+ Privatekey works fine for the user's own bookmarks
- Does not work with all bookmarks (plain rss.php?privatekey) - I'm
  likely to subscribe to the all bookmarks feed in a private SC setup
  with a several users.
+ Enabling and disabling the private key works fine
+ Error page when accessing feed with wrong private key
+ Error page when accessing feed with disabled private key
- Generating new key throws away form changes. This isn't that nice,
  but I'll accept it for now and we can fix that when the quickform
  branch is finished.
- 1) BookmarkTest::testPrivateBookmarks
  Undefined offset: 1
  /home/cweiske/Dev/semanticscuttle/cwdev/tests/BookmarkTest.php:1387

I did also run the unit tests with with coverage enabled and saw that
i.e. "getUserByPrivateKey" is not tested. I'll help you with writing
the tests.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-