Re: [Semanticscuttle-devel] Status for configurable privacy ....

[Brett D. <bs...@fr...>]

Hello, Christian.

I have completed my unit tests and will likely check in my changes
Tuesday. I have some concerns about the fact that there were Windows
carriage returns in my last check-in. I am working on a Windows
environment--I will eventually set up a Linux environment, but not for a
few weeks at least--but I've been editing files with vi on Cygwin and
MKS Toolkit, so there should not have been any Windows carriage returns.
Any tips/advice you have concerning this would be appreciated.

Here are a few things I noticed when testing import.php and
importNetscape.php:
1. import.php points the user to http://del.icio.us/api/posts/all to
save bookmarks to an XML file. This is evidently not a good option any
longer for "new" del.icio.us users who are using a Yahoo! ID to access
their bookmarks. A better option for these users is to go to the
Delicious XML Exporter at http://deliciousxml.com/. Otherwise, they must
use http://api.del.icio.us/v2/posts/all with open authorization, and
that complicates the process somewhat.
2. I think I may have found a bug in importNetscape.php, which ignores
the last bookmark in the specified HTML file. I think this is occurring
in the regular expression given as the first parameter of the 
preg_match_all function call. Consequently, my test data contains a
last entry that I have assumed will be ignored. The test will need to be
updated if this behavior in importNetscape.php changes.

Also, I will be creating a data directory below the tests directory to
keep the test data for import.php and importNetscape.php.

Rgrds,
Brett

On Tue, 22 Mar 2011 06:57:55 +0100, Christian Weiske
<cw...@cw...> wrote:
> Hello Brett,
> 
> 
>> I've written a unit test for posts_add.php and will write additional
>> asserts for the other affected files this week.
>>
>> I think I will need to create a bookmark file with data for testing
>> import.php and importNetscape.php. I assume I should just place this
>> file in the tests directory, correct?
> Yep. Although I begin to think that we should create a data/ directory
> inside tests/ and put the file in there so they don't clutter up the
> tests dir itself. Please prefix the file names with the test class
> name, i.e. "UserTest-netscape.html".