Re: [Semanticscuttle-devel] Feature request #3164348: Make default privacy configurable

[Christian W. <cw...@cw...>]

Hi Brett,


> This is in regards to feature request #3164348
> [http://sourceforge.net/tracker/?func=detail&aid=3164348&group_id=211356&atid=1017433],
> "Make default privacy configurable."
> 
> Privacy can be made configurable when the bookmark is added by the
> modifications described in the feature request, but the assignment to
> 'bStatus' is also made 16 lines before in the preceding if block. In
> the event that POST_TAGS is not set, an array is created with a
> default bStatus value of 0. I think this should also be set to the
> global default:
The idea is correct, but you missed some points where bookmarks are
added/updated:
- www/bookmarks.php (what you probably meant)
- www/edit.php
- www/api/posts_add.php

All of them need to be modified, and you will need to add unit tests to
verify it works.


> 'tags' => (POST_TAGS ? explode(',', stripslashes(POST_TAGS)) :
> array()),
>                 'bStatus' => $GLOBALS['privacy_default'], //New
> assignment.
> 		//'bStatus' => 0, //Old assignment.
>            );
We need to structure the settings a bit, so I'd call the variable
> $GLOBALS['defaults']['privacy']
You should add it to the config.defaults.php, too.

I'd say go on and implement it in a new feature branch, i.e.
configurable-privacy.

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-