[Semanticscuttle-devel] Feature request #3164348: Make default privacy configurable

[Brett D. <bs...@fr...>]

Hi all,

This is in regards to feature request #3164348
[http://sourceforge.net/tracker/?func=detail&aid=3164348&group_id=211356&atid=1017433],
"Make default privacy configurable."

Privacy can be made configurable when the bookmark is added by the
modifications described in the feature request, but the assignment to
'bStatus' is also made 16 lines before in the preceding if block. In the
event that POST_TAGS is not set, an array is created with a default
bStatus value of 0. I think this should also be set to the global
default:

'tags' => (POST_TAGS ? explode(',', stripslashes(POST_TAGS)) :
array()),
                'bStatus' => $GLOBALS['privacy_default'], //New
assignment.
		//'bStatus' => 0, //Old assignment.
           );

Let me know if you have other suggestions/thoughts.

Thanks and Regards,
Brett


On Fri, 28 Jan 2011 06:24:20 +0100, Christian Weiske
<cw...@cw...> wrote:
> Hi Brett,
> 
> 
>> I am new to open-source work and am currently familiarizing myself
>> with git and the product code. I think this will be primarily a
>> learning experience for me for a few weeks at least.
> 
> That's totally fine. There is no need to rush, and we have plenty of
> small tasks you can do to get into the code. If you need help, just
> send a mail to the mailing list or join me/us in #semanticscuttle on
> freenode. If you have jabber/xmpp, you might add cw...@cw... to
> your contact list.
> 
> Btw, the mailing list is on 
> https://sourceforge.net/mailarchive/forum.php?forum_name=semanticscuttle-devel
> 
> You should at first get familiar with SemanticScuttle itself - download
> it, install it and get it to work on your own machine.
> 
> Since you are very new, you might implement a small feature request:
>> "Make default privacy configurable"
> http://sourceforge.net/tracker/?func=detail&aid=3164348&group_id=211356&atid=1017433
> 
> The steps to take are:
> 1. Find out what the things are needed to do to implement the feature
> 2. Look at the code and see what needs to be done where to do it
> 3. Write that up and send it to the mailing list. We can discuss it then
> 4. Create your own feature branch (i.e. "configurable-privacy") from
>    master and implement it in there
> 5. Push the branch to sourceforge so I can review it.
> 6. If everything is fine, I will merge it into the master branch
> 
> If you find out that that's not your thing, you could help at
> other places, i.e. the documentation.