Re: [Semanticscuttle-devel] regarding "help wanted" post / a first task
Brought to you by:
cweiske
From: Christian W. <cw...@cw...> - 2011-02-01 07:34:34
|
Hi Golanor, > ok, I subscribed to the mailing list and got the code from git. The first - easy - task for you to solve could be bug #3097187 [1] The steps to take are: 1. Find out what the things are needed to do to implement the feature 2. Look at the code and see what needs to be done where to do it (this might be a bit overkill for that bug, but it is important when implementing new features) 3. Write that up and send it to the mailing list. We can discuss it then 4. Create your own feature branch (i.e. "fix-twoword-opensearch") from master and implement it in there 5. Push the branch to sourceforge so I can review it. 6. If everything is fine, I will merge it into the master branch Please consider the following things: 1. SemanticScuttle tries to follow the PEAR Coding Standards. Use the PHP_CodeSniffer tool from PEAR to make sure you don't leave more style errors than there were when you began working on the file. Not all files comply to the styles yet, but we're on the right track 2. We have unit tests. Run them. Make sure that they still work when you finished your task. Better: Write a test for your own bug first - it should fail. Then fix the bug, and your test should work now. 3. If you find other bugs, open a bug report. 4. Do not fix several things in one branch. This really makes it hard to merge changes into the master branch. Creating a new branch in git is cheap, so use that. 5. Update the Changelog 6. I repeat myself, but: Only commit in your own branches. [1] https://sourceforge.net/tracker/?func=detail&atid=1017430&aid=3097187&group_id=211356 -- Regards/Mit freundlichen Grüßen Christian Weiske -=≡ Geeking around in the name of science since 1982 ≡=- |