Re: [Semanticscuttle-devel] Updates to privatekey branch (aka Private Rss Feed)

[Christian W. <cw...@cw...>]

Hi Mark,



> Hey guys, I've pushed the latest changes to the privatekey branch that
> contains two things.
> 
> First, I did some code cleanup which helped me get more familiar with
> the code base.
> 
> Second, I'm mostly done with the private RSS feed changes as per
> feature request # *3164013*.
> 
> What's still pending:
> 1) make either an update utility or change the tables.sql to include
> some code that auto populates the new user column with a unique md5()
> value.
The update utility is something I'd like to see ([1], [2]), but it's
not as easy as one might think :)
For now, please add the upgrade SQL statements to doc/UPGRADE.txt
and make sure that people without a private key in the database cannot
use the private bookmark feature.

> 2) I've only changed the bookmarks.php page to show the
> additional RSS feed. Before I propagate that change to the other
> pages with rss feeds, I'd like to specifically ask for thoughts on
> distinguishing the difference between the feeds.  Is the hover-text
> enough, or do we need to have a different icon for the private feed
> (like the common blue one).
I'd actually remove the feed icon from the pager and only keep the
icons in the HTML head (<link rel="alternate"/>).

Did you run the unittests yet? I think you have to adjust them and add
tests for your new functionality. Beware that running them will empty
the database, so back it up first.



[1] http://cweiske.de/tagebuch/php-installer-first.htm
[2]
http://cweiske.de/tagebuch/Generic%20PHP%20application%20installers.htm

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-= Geeking around in the name of science since 1982 =-