[Secureideas-base-devel] Re: [PATCH] various patches for BASE 1.1.4

[Alex B. ISC/I. <Ale...@br...>]

Hi -

--On 27 August 2005 19:55 -0400 Kevin Johnson <kjo...@se...> 
wrote:

> On Fri, 2005-08-26 at 12:04 +0100, Alex Butcher, ISC/ISYS wrote:
>> Attached are a number of patches that I created for our local deployment
>> of  ACID, and that I've finally gotten round to porting to BASE.
>>
>
> We appreciate the help.  And I have gone through the patches.  I have
> applied a few of them and am still looking at others to see how is the
> best way to use them.  See below for comments and questions please...
> I have also copied the developers list to get everyone's feedback and
> have the testers start testing the changes.<g>

Cool. My original patches against ACID have been in production use for over 
a year locally, but the ports to BASE have only been lightly tested, and 
it's entirely possible I stuffed something up along the way. ;-)

Re. user-definable paths: in all cases, this is a Good Thing. I, however, 
was lazy. :-) I also had to include base_conf.php in a _inc.php (for the 
extwhois patch, and I'm fairly sure this isn't really a nice thing to do.

Also, I'm well aware that some of the patches aren't really generally 
applicable (e.g. getpacket/payload), but I figured I'd fling the lot at you 
and let you decide what to keep.

>> extwhois
>> - uses an external whois binary to perform whois lookups, rather than
>> doing  this in PHP to a limited number of whois servers. The version of
>> whois on  many OSs now knows how to find the appropriate whois server
>> automatically.
>
> Not sure this will work everywhere, for example Windows.  So I am
> looking at making it an option in base_conf.php.  Other then that I
> really like this one too.

Oops! Yeah, I forgot some OSs are still stuck in the 20th century. :-/

Best to make it a config option.

>> Alex.
>
> Thanks again!
> Kevin

Best Regards,
Alex.
-- 
Alex Butcher: Security & Integrity, Personal Computer Systems Group
Information Systems and Computing             GPG Key ID: F9B27DC9
GPG Fingerprint: D62A DD83 A0B8 D174 49C4 2849 832D 6C72 F9B2 7DC9