Small Device C Compiler (SDCC) / Patches / #286 Check strcpy arguments equality in sdas

#286 Check strcpy arguments equality in sdas

Milestone: None

Status: closed-fixed

Owner: Philipp Klaus Krause

Labels: None

Priority: 5

Updated: 2018-06-27

Created: 2018-06-19

Creator: Márton Miklós

Private: No

I was unable to compile source code on OSX if the sources was at the same level as the Makefile.
After some debugging it turned out that the strcpy was called with two identical arguments which generated an error. The attached patch fixes this issue.

1 Attachments

patch0001.diff

Discussion

Philipp Klaus Krause - 2018-06-21

Thanks for spotting the bug and for the proposed fix.

I think it could still happen that the destination and source strings overlap, even when the arguments are not identical, so in [r10452], I choose an alternative solution, that also deals with that case.

Could you test that it fixes your issue?

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Márton Miklós - 2018-06-27
  
  Hello Philipp,
  
  I agree that you approach is better than mine.
  
  I have tested it on OSX and works fine.
  
  Thank you for your time and efforts!
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-06-21

assigned_to: Philipp Klaus Krause

Group: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-06-27

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Check strcpy arguments equality in sdas

The Small Device C Compiler (SDCC), targeting 8-bit architectures

Group

Searches

Help

#286 Check strcpy arguments equality in sdas

Discussion