[z80] Hardcoded "#0xNN"-like numbers elimination

The Small Device C Compiler (SDCC), targeting 8-bit architectures

Brought to you by: benshi, drdani, epetrich, jesusc, and 3 others

#176 [z80] Hardcoded "#0xNN"-like numbers elimination

Status: closed-accepted

Owner: Philipp Klaus Krause

Labels: z80 port (16)

Priority: 5

Updated: 2012-06-16

Created: 2012-03-29

Creator: Alexander Tsidaev

Private: No

There were few hardcoded numbers in "#0xNN" notation in the gen.c
Assemblers other than asxxxx consider them as errors.

Solution: replaced using !immedbyte/!immedword.

Related

Discussion

Alexander Tsidaev - 2012-03-29

summary: [z80] Hardcoded numbers of "#0xNN" type elimination --> [z80] Hardcoded "#0xNN"-like numbers elimination

Related

Wiki: z80
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alexander Tsidaev - 2012-03-29

immed.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alexander Tsidaev - 2012-03-29

But I have not idea what to do with commands that can use negative numbers like
int d = (stack < 127 ? -stack : -127);
emit2 ("add sp, #%d", d);

both !immedbyte and !immedword are replaced with 32-bit long number when parameter is negative:
emit2("add sp, !immedbyte", -15) give us "add sp, #0xFFFFFFF1"
Is this a bug?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2012-06-15

assigned_to: nobody --> spth

status: open --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2012-06-15

Implemented for all "#0x" in revision #7917.

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2012-06-15

Keeping it open for the other #-prefixed stuff.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2012-06-15

status: closed-accepted --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2012-06-16

The !immedword substitution was applied in revision #7919. AFAIk there currently is no mechanism like this for negative numbers.

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2012-06-16

status: open-accepted --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.