From: Sandeep D. <sa...@dd...> - 2001-02-18 16:01:28
|
Yup I remember the discussion. Don't worry about it. Some people had complained about my indentation style before, so it is all the best . Just got surprised a little with the new layout :-) have adjusted my emacs setting now.... Sandeep -----Original Message----- From: sdc...@li... [mailto:sdc...@li...]On Behalf Of Johan Knol Sent: Sunday, February 18, 2001 2:27 AM To: sdc...@li... Subject: Re: [sdcc-devel]PIC port commits I know and agree. But since lots of files were, by mistake, made unreadable outside the M$VC IDE (e.g. SDCCmain.c:1.48), I proposed to do this just once. I mentionded the major draw back. We discussed this, even the coding style, and no one really objected. I did it at a moment when it was extreme quiet. ----- Original Message ----- From: Sandeep Dutta <sa...@dd...> To: <sdc...@li...> Sent: Sunday, February 18, 2001 7:41 AM Subject: RE: [sdcc-devel]PIC port commits > I absolutely agree with , let this be the last time, we "beautify". > Diffing with previous versions becomes impossible. > > Sandeep > > -----Original Message----- > From: sdc...@li... > [mailto:sdc...@li...]On Behalf Of Stephen > Williams > Sent: Saturday, February 17, 2001 9:08 PM > To: sdc...@li... > Subject: Re: [sdcc-devel]PIC port commits > > > > sc...@da... said: > > I'd say that 198 of these were from diff getting confused between the > > beautifier changes being made to the same routines that I was making > > (non-beautiful) changes. > > I feel for you. > > First rule of working cooperatively on a software project: never ever > "beautify" the source code. In fact, if you are making changes to some- > one else's code, it is best to match the coding style (at least as much > as your stomach will allow.) > > anyhow, if it really matters, there are CVS logs which should tell you > who made what changes, and there should be a log entry that said user > added to justify the change. > -- > Steve Williams "The woods are lovely, dark and deep. > st...@ic... But I have promises to keep, > st...@pi... and lines to code before I sleep, > http://www.picturel.com And lines to code before I sleep." > > > > _______________________________________________ > sdcc-devel mailing list > sdc...@li... > http://lists.sourceforge.net/lists/listinfo/sdcc-devel > > > > _______________________________________________ > sdcc-devel mailing list > sdc...@li... > http://lists.sourceforge.net/lists/listinfo/sdcc-devel > _______________________________________________ sdcc-devel mailing list sdc...@li... http://lists.sourceforge.net/lists/listinfo/sdcc-devel |