Re: [sdcc-devel] comitted: cleaned up a lot, some problems left

[Johan K. <joh...@id...>]

----- Original Message -----
From: Kevin Vigor <kv...@en...>
To: <sdc...@li...>
Sent: Saturday, September 30, 2000 11:47 PM
Subject: RE: [sdcc-devel] comitted: cleaned up a lot, some problems left


>
> On 30-Sep-2000 Johan Knol wrote:
> > I left the repository in a broken state
>
> Please don't do that! There are other people, in other time zones,
> working on this code.

Yes, you are right. I was too tired to realize that.

> And by the way, I strongly recommend against using -Werror in our
> makefiles. You get weird warnings on various platforms out there; for
> instance, on a Solaris x86 machine I use, a disagreement between gcc
> and the system headers causes a warning ('subscript has type `char'')
> for every function in ctypes.h. No matter how clean your code, it'll
> get a warning on some weird platform out there, and the user will just
> have to go in and hack out the -Werror.

I STRONGLY disagree with you here. If you are using broken tools you can't
garantee to produce proper products. Instead of killing our guardian angel
(by hacking out -Werror), people should sharpen/repair their tools first.

Or perhaps we need something like "if (!(LousyOS || BrokenTools ||
LazyProgrammer)) CFLAGS+=-Werror" in our configure scripts.

Any way, I removed the -Werror

Johan