From: SourceForge.net <no...@so...> - 2010-08-15 21:20:23
|
Bugs item #3041470, was opened at 2010-08-08 13:00 Message generated for change (Comment added) made by borutr You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100599&aid=3041470&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: assembler Group: fixed Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Maarten Brock (maartenbrock) Assigned to: Maarten Brock (maartenbrock) Summary: buffer overflow in assembler Initial Comment: When I run the regression tests with the --debug flag the assembler crashes with a buffer overflow. Processing uminus.c *** buffer overflow detected ***: ../../bin/sdas6808 terminated Processing uminus.c *** buffer overflow detected ***: ../../bin/sdas8051 terminated Processing uminus.c *** buffer overflow detected ***: ../../bin/sdasz80 terminated Tested with svn revision 5917. ---------------------------------------------------------------------- >Comment By: Borut Ražem (borutr) Date: 2010-08-15 23:20 Message: Hi Maarten, this bug disclosed two probems: - the first one is that the diferrent identifiers match in first 80 characters. I haven't check the c standard yet, but I found this: http://publications.gbdirect.co.uk/c_book/chapter2/keywords_and_identifiers.html, so I don't know if this is really a sdcc bug, or we should somehow redesign the regression teting. But at this level I agree with your fix, even that I would be more satisfied if dsas / sdld would accept identifiers of arbitrary lenght (using malloc instead fixed lenght buffers). - the second one is: why it crashes? I took a quick look to the code and I didn't find the buffer overflows (neither did you fix them). Currently I can't chek it, since I'm on the WIN32 / cygwin machine which doesn't crash (the compiler doesn't produce run-time buffer overflow checks). Do you already know something more about it? Borut ---------------------------------------------------------------------- Comment By: Maarten Brock (maartenbrock) Date: 2010-08-15 22:39 Message: Fixed by enlarging NCPS in the assembler in revision #5932. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100599&aid=3041470&group_id=599 |