[sdcc-devel] [ sdcc-Feature Requests-2931693 ] deprecate warnings for sdcc specific keyword

[SourceForge.net <no...@so...>]

Feature Requests item #2931693, was opened at 2010-01-14 00:07
Message generated for change (Comment added) made by borutr
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=350599&aid=2931693&group_id=599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: Borut Ražem (borutr)
Assigned to: Borut Ražem (borutr)
Summary: deprecate warnings for sdcc specific keyword

Initial Comment:
Introduce deprecate warnings for sdcc specific keywords, not preceded with  two underlines (data, code, idata, xdata, sfr, at, interrupt, using, ...) and announce in the  documentation that they will be removed in the future.

----------------------------------------------------------------------

>Comment By: Borut Ražem (borutr)
Date: 2010-08-05 06:55

Message:
--std-c89 or --std-c99 command line options should help.

Borut

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2010-08-05 02:07

Message:
We are trying SDCC for certain HW platform support in our operating system
MansOS.

Our code has variables or fields named 'data' all over the place. Never
had problems with gcc.

The latest SDCC from svn (2.9.7 #5904 (Aug  5 2010) (Linux)) tells me
'data' is depreciated. Good.

But is there any way to remove the depreciated keywords now (with a switch
or pragma) so that our code compiles?
Otherwise we get errors, not just warnings. An example follows. 
Thanks. --Leo

...the error...
kernel/devmgr.h:82: syntax error: token -> ';' ; column 15

...the code...
typedef union {
    char *data;             //  (line 82 !!!)
    struct {
        uint8_t length;
        char * data;
    } ld;           
    struct {
        uint16_t length;
        char * data;
    } ld16;      
    fpEvent_t eventHandler;
} devParams_t;

========

----------------------------------------------------------------------

Comment By: Borut Ražem (borutr)
Date: 2010-01-14 20:53

Message:
I already wrote to the sdcc-mailing list:

"If somebody really don't want to see the warnings, he can use "#pragma
disable_warning 197" in the source file or "--disable-warning 197" command
line option."

But this won't work any more when the deprecated keywords will be removed
sometime in the future, so the header file will be the only option for
those that can't or don't want to change the deprecated keywords for one
reason or another.

I actually don't know how much trouble my change caused to the sdcc users.
I prepared and attached the old_keywords.h header file, since I don't want
to include it to the sdcc distribution, at least not before somebody shows
me that he really can't live without it.

Until now I received only comments from Maarten and Jesus, but I don't
consider them as "typical sdcc users" and I'm convinced that they can
handle the problem by their self ;-)
Let wait and see how the "typical" sdcc users will react...

Borut

----------------------------------------------------------------------

Comment By: Maarten Brock (maartenbrock)
Date: 2010-01-14 16:52

Message:
Maybe we can create a new header file with macros for the old keywords
defined in their new form. This will silence the warnings (and future
errors) but still gives users an easy migration path.

----------------------------------------------------------------------

Comment By: Borut Ražem (borutr)
Date: 2010-01-14 00:39

Message:
Implemented in svn revision #5631.
The documentation is not updated yet.

Borut

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=350599&aid=2931693&group_id=599