[sdcc-devel] [ sdcc-Patches-2704189 ] character constant sign fix

[SourceForge.net <no...@so...>]

Patches item #2704189, was opened at 2009-03-22 22:04
Message generated for change (Comment added) made by borutr
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2704189&group_id=599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Robert Larice (rlar)
>Assigned to: Borut Ražem (borutr)
Summary: character constant sign fix

Initial Comment:
sdcc per default treats chars as signed chars.
but unfortunately literal character constants 's' ...
   are treated as unsigned chars.
furthermore the --funsigned-char commandline switch
  should have effect on literal char constants,
  but does not.
furthermore the CHAR_MAX and CHAR_MIN constants
  in limits.h should change when --funsigned-char is
  given.
and finally there is a library routine which 
  accidently uses CHAR_MAX instead of SCHAR_MAX

the attached patch tries to fix that, 
  introduces a new preprocessor token SDCC_CHAR_UNSIGNED
  a regression test,
  and add a stanca in the documentation.

rlar



----------------------------------------------------------------------

>Comment By: Borut Ražem (borutr)
Date: 2009-03-23 07:23

Message:
Patch applied in svn revision #5421.
Thanks, Robert!

Borut

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2704189&group_id=599