From: Maarten B. <sou...@ds...> - 2008-03-09 22:12:18
|
Bug 1505811 is indeed nothing PIC specific and fails on all targets. The patch by Robert also seems to fix it. But I think it is too strict. IMO it should check if this sym is used to find the function it wants to call. I propose: case CALL: /* if local & not passed as parameter & not used to find the function then ok */ if (sym->level && !astHasSymbol (pbody->right, sym) && !astHasSymbol (pbody->left, sym)) { return TRUE; } return FALSE; Borut, what do you say? Shall I fix it or will it have to wait? Maarten > On Sun, 9 Mar 2008, Borut Razem wrote: > > > Dear sdcc developers, > > > > please consider the svn main branch as frozen, which means that only fixes for high severity bugs (after an agreement on this mailing list) and changes in the documentation can be committed. > > > > The SDCC 2.8.0 release schedule is published at http://sdcc.sourceforge.net/release_wiki/index.php?page=SDCC+2.8.0+Release. > > > > Borut > > May I suggest to apply the patch in > http://sourceforge.net/tracker/index.php?func=detail&group_id=599&atid=100599&aid=1505811 > > thats an uggly bug, which was very easy to fix. > > Robert Larice |