[sdcc-devel] [ sdcc-Feature Requests-1746528 ] SDCC should ignore ':' in inline assembler comments

[SourceForge.net <no...@so...>]

Feature Requests item #1746528, was opened at 2007-07-02 15:34
Message generated for change (Settings changed) made by borutr
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=350599&aid=1746528&group_id=599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Priority: 5
Private: No
Submitted By: Frieder Ferlemann (frief)
Assigned to: Borut Ražem (borutr)
Summary: SDCC should ignore ':' in inline assembler comments

Initial Comment:
Currently SDCC does not allow to directly reuse assembly snippets which are cut and pasted from the generated .asm file.

If these are enclosed within an "__asm" "__endasm" pair  the assembler bails out. 

(SDCC adds a newline within the comment line ";       asx_test.c:5: counter++;"
and the assembler then sees the C-statement "counter++;" on a seperate line.)



-----8<--------------------------------------------------
volatile unsigned char counter;

void main(void)
{
  counter++;
  counter++;
}

// this is a cut and paste of asx_test.asm and it should
// compile "as is"
// But it stumbles over the second ':' followed by a
// whitespace character in the outcommented lines.
//
// This seems to be caused by genInline() in src/mcs51/gen.c
// which inserts an additional '\n' when it should not.
//
void inline_example(void) __naked
{
__asm
;       asx_test.c:5: counter++;
        inc     _counter
;       asx_test.c:6: counter++;
        inc     _counter
__endasm;
}



----------------------------------------------------------------------

Comment By: Borut Ražem (borutr)
Date: 2007-07-03 21:52

Message:
Logged In: YES 
user_id=568035
Originator: NO

Fixed in svn revision #4874.

Borut

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=350599&aid=1746528&group_id=599