Menu
▾
▴
[sdcc-devel] [ sdcc-Patches-1646602 ] option to set default signedness of char to unsigned
|
From: SourceForge.net <no...@so...> - 2007-01-31 15:47:21
|
Patches item #1646602, was opened at 2007-01-28 22:23 Message generated for change (Comment added) made by borutr You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=1646602&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Günther Jehle (jehle) Assigned to: Nobody/Anonymous (nobody) Summary: option to set default signedness of char to unsigned Initial Comment: The default signedness of a data type without the signed or unsigned keyword is signed. In some embedded enviornments, the type char is unsigned, if no signedness keyword is given. This patch adds the option --unsigned-char-default, which changes the frontend to set a char type to unsigned, if no signedess keyword is given. The patch includes the changes in the documentation. Regards Guenther Jehle ---------------------------------------------------------------------- >Comment By: Borut Razem (borutr) Date: 2007-01-31 16:47 Message: Logged In: YES user_id=568035 Originator: NO Günther, I think that I'm thinking too much :-( Forget about my proposal in the previous post. Borut ---------------------------------------------------------------------- Comment By: Borut Razem (borutr) Date: 2007-01-31 15:49 Message: Logged In: YES user_id=568035 Originator: NO Günther, after thinking over I belive that it would be better and more consistent with the current design to make changes in SDCCsymt.c instead of SDCC.y. What do you think? Are you willing to prepare an other patch in case that you agree with my proposal? Frieder, I defenitely agree with you to use the same command line otions as GCC when possible / applicable. I already used such approach for -fdollars-in-identifiers. So -funsigned-char will be! Borut ---------------------------------------------------------------------- Comment By: Frieder Ferlemann (frief) Date: 2007-01-31 09:21 Message: Logged In: YES user_id=589052 Originator: NO Hi, a note about the naming of the option: gcc would use the option -funsigned-char instead of -unsigned-char-default. Of course both namings are equally valid but as SDCC includes gcc's preprocessor anyway we should maybe adopt gcc's naming for newly added options? Greetings and thanks! Frieder ---------------------------------------------------------------------- Comment By: Borut Razem (borutr) Date: 2007-01-31 07:35 Message: Logged In: YES user_id=568035 Originator: NO Günther, I took very quick look to the patch and I think is OK, but we have to prove it ;-) Can you prepare a regression test for it? Unfortunately sdcc test suite currently doesn't support compilation with different command line options, so a regression test which requires special cmdline options can not be included in the suite. Thank you for the patch, Borut ---------------------------------------------------------------------- Comment By: Günther Jehle (jehle) Date: 2007-01-29 02:00 Message: Logged In: YES user_id=1301993 Originator: YES found a forum entry corresponding to this issue: http://sourceforge.net/forum/message.php?msg_id=3606879 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=1646602&group_id=599 |