[sdcc-devel] [ sdcc-Bugs-1490124 ] error on (*fp[index ])();

[SourceForge.net <no...@so...>]

Bugs item #1490124, was opened at 2006-05-17 11:59
Message generated for change (Comment added) made by maartenbrock
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100599&aid=1490124&group_id=599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: msc51(8051) target
Group: None
>Status: Pending
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: error on (*fp[index ])(); 

Initial Comment:
from:
ber...@wo...


>>>>>don't work (index is a byte) error on 2nd byte of
adress loaded
I propose in 1283 1284 
xch a,R2
inc a 

(* fp[ index ])();
corresponding assembler
 0207 E2                 1266 	movx	a,@r0
                           1267 ;     genLeftShift
                           1268 ;     genLeftShiftLiteral
                           1269 ;     genlshOne
   0208 FA                 1270 	mov	r2,a
                           1271 ;	Peephole 105	removed
redundant mov
   0209 25 E0              1272 	add	a,acc
                           1273 ;     genPlus
                           1274 ;	Peephole 177.b
removed redundant mov
                           1275 ;	Peephole 181	changed
mov to clr
                           1276 ;     genPointerGet
                           1277 ;     genCodePointerGet
                           1278 ;	Peephole 181	changed
mov to clr
                           1279 ;	Peephole 186.d
optimized movc sequence
                           1280 ;	Peephole 188	removed
redundant mov
   020B 90s00r00           1281 	mov	dptr,#_motor_fp
   020E 93                 1282 	movc	a,@a+dptr
>>>>>>>   020F FA                 1283 	mov	r2,a
>>>>>>>   0210 74 01              1284 	mov	a,#0x01
   0212 93                 1285 	movc	a,@a+dptr
   0213 FB                 1286 	mov	r3,a
                           1287 ;     genPCall
   0214 C0 02              1288 	push	ar2
   0216 C0 03              1289 	push	ar3



>>>>>work
(* fp[(unsigned) index ])();

corresponding assembler:
                          1264 ;     genPagedPointerGet
   0207 E2                 1265 	movx	a,@r0
   0208 FA                 1266 	mov	r2,a
                           1267 ;     genCast
                           1268 ;     genLeftShift
                           1269 ;     genLeftShiftLiteral
                           1270 ;     genlshTwo
                           1271 ;	peephole 177.g
optimized mov sequence
     
                      1272 ;	Peephole 181	changed mov
to clr
   0209 E4                 1273 	clr	a
   020A FB                 1274 	mov	r3,a
   020B CA                 1275 	xch	a,r2
   020C 25 E0              1276 	add	a,acc
   020E CA                 1277 	xch	a,r2
   020F 33                 1278 	rlc	a
   0210 FB                 1279 	mov	r3,a
                           1280 ;     genPlus
                           1281 ;	Peephole 236.g	used
r2 instead of ar2
   0211 EA                 1282 	mov	a,r2
   0212 24r00              1283 	add	a,#_motor_fp
   0214 F5 82              1284 	mov	dpl,a
                           1285 ;	Peephole 236.g	used
r3 instead of ar3
   0216 EB                 1286 	mov	a,r3
   0217 34s00              1287 	addc	a,#(_motor_fp >> 8)
   0219 F5 83              1288 	mov	dph,a
                           1289 ;     genPointerGet
                           1290 ;     genCodePointerGet
                           1291 ;	Peephole 181	changed
mov to clr
   021B E4                 1292 	clr	a
   021C 93                 1293 	movc	a,@a+dptr
   021D FA                 1294 	mov	r2,a
   021E 74 01              1295 	mov	a,#0x01
   0220 93                 1296 	movc	a,@a+dptr
   0221 FB                 1297 	mov	r3,a
                           1298 ;     genPCall
   0222 C0 02              1299 	push	ar2
   0224 C0 03              1300 	push	ar3
 

----------------------------------------------------------------------

Comment By: Maarten Brock (maartenbrock)
Date: 2006-05-17 14:33

Message:
Logged In: YES 
user_id=888171

This can't be reproduced in 2.5.6. Can you confirm it still  
exists? 
 

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2006-05-17 13:03

Message:
Logged In: NO 

 same as 1434401

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100599&aid=1490124&group_id=599