From: SourceForge.net <no...@so...> - 2006-05-15 23:42:41
|
Webdocs item #1410936, was opened at 2006-01-20 17:52 Message generated for change (Comment added) made by frief You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=536150&aid=1410936&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Website Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Nobody/Anonymous (nobody) Assigned to: Maarten Brock (maartenbrock) Summary: LPC9xx headers to be used with SDCC Initial Comment: These headers are very useful for everyone who works with the Philips family and SDCC. I personally tested them, but if you find a mistake, I would be happy of hearing from you It can be downloaded from www.8052.com/users/omarE ---------------------------------------------------------------------- >Comment By: Frieder Ferlemann (frief) Date: 2006-05-16 01:42 Message: Logged In: YES user_id=589052 Ooops, the files P89*.h that were added use upper case filenames. Thanks for adding, but: In unix environments this is considered the equivalent of SHOUTING. (Upper case filenames usually would be sorted on top, that is they'd appear even before a Readme file). Please let's have all include file names lower case! Longer explanation: Trying to reliably transport any kind of information via the casing of filenames is in vane: Early DOS filenames came upper case only (quite a few include files date back to that area), and some Windows filename conversion tools did silently convert their first characters to upper case and the rest to lower case. Additionally Windows flavours of most C compilers do not warn about different filename casings (which is consistent with ANSI C which leaves these minor details to the operating systems filename matching). So casing of filenames cannot be relyed upon in source code that has been in contact with a Windows operating system. This is a recurring annoyance for users on unix systems which have to suffer from the collateral damages of the (fortunate or unfortunate depending on your point of view) design decision Microsoft has made. Unix users seem to have to adapt the #includes for most but the smallest projects. If portability is one of our rationales, please let's have all lower case filenames! (also for the existing XC866.h:) ---------------------------------------------------------------------- Comment By: Maarten Brock (maartenbrock) Date: 2006-05-15 22:11 Message: Logged In: YES user_id=888171 With permission from Omar I have made small updates and uploaded these headers to SDCCs subversion tree. Also inserted LGPL with Omars permission. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2006-01-20 18:20 Message: Logged In: NO look fine, but some minor remarks: - the files seem to use an evil tabulator spacing of 4. Please convert to spaces or use a tabulator spacing of 8. - with the Copyright (c) notice as it is now noone will be allowed to use it - which is probably not what you want:) - maybe you could use the notation "__sfr __at (0xC8) T2CON" as in: http://cvs.sourceforge.net/viewcvs.py/sdcc/sdcc/device/include/mcs51/8052.h?view=markup (This notation allows to remove the __at (0xC8) with a preprocessor #define). Greetings, Frieder ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=536150&aid=1410936&group_id=599 |