Small Device C Compiler (SDCC) / Bugs / #2752 inline and __reentrant causes bad code generation on MCS51

Philipp Klaus Krause - 2018-05-27

Priority: 5 --> 7
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-05-27

This bug also affects ds390 (but not other backends, in particular it does not affect hc08 despite that one otherwise being similar inhandling of reentrancy).

In [r10413], I added a test (currently disabled for mcs51 and ds390).

Increasing priority, since bad code is generated silently.

Philipp

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Philipp Klaus Krause - 2018-05-27

This bug also affects ds390 (but not other backends, in particular it does not affect hc08).

In [r10413], I added a test (currently disabled for mcs51 and ds390).

Increasing priority, since bad code is generated silently.

Philipp

P.S.: However, hc08 also does an apparently unnecessary stack adjustment by 2, it hust readjusts the stack accordingly at function exit, so it only wastes stack space, but does not jump into the void.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Erik Petrich - 2018-06-04

status: open --> closed-fixed

assigned_to: Erik Petrich
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Erik Petrich - 2018-06-04

Fixed in [r10420]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -1,4 +1,4 @@
-Calling a function decorated with both inline and __reentrant causes bad code generation on MCS51. In the example below, SDCC inserts two rogue inc sp instructions. When I remove __reentrant, the code looks correct
+Calling a function decorated with both inline and \_\_reentrant causes bad code generation on MCS51. In the example below, SDCC inserts two rogue inc sp instructions. When I remove \_\_reentrant, the code looks correct

 Command to compile:
 sdcc-sdcc -c x.c

inline and __reentrant causes bad code generation on MCS51

The Small Device C Compiler (SDCC), targeting 8-bit architectures

Searches

Help

#2752 inline and __reentrant causes bad code generation on MCS51

Discussion