#6822 AGOS: Elvira 1 - Amiga music issue

[Slowtide]

I have just noticed an issue with the music in the amiga version of Elvira 1.

It seems that the arpeggio effect used in the MOD-Soundtrack of this game has not been implemented correctly in scummvm. While only a minor issue, it might also affect other games that use MOD-tracker soundtracks.

This can be noticed particularly in the track "catacombs.mod" which is used right at the beginning of the game, when the player takes one step towards the castle.

This youtube video gives a hint on how it's supposed to sound:
https://www.youtube.com/watch?v=FuDzQLx4wP4
The effect can be heard in in 0:24 e.g.

ScummVM version - 1.7.0
Language of game - English
Version of game - Amiga
Platform and Compiler - Windows 7, 64 bit

[Thomas Fach-Pedersen]

I had a quick look-see through (what appears to be) DrMcCoy's implementation of arpeggio, and it looks like it expects arpeggio only if a note is specified, while the mod expects arpeggio to work on the currently playing note.

I made a quick patch to base the arpeggio on the active note instead, and it sounds a lot better. I haven't studied the arpeggio implementation in detail, though.

[kirben]

Fixed in ScummVM GiT, thanks to the patch from madmoose.

Use the next daily snapshot of ScummVM GiT.