#5669 HUGO: Whodunit? crashes on opening the top bar icons

ScummVM 1.3.0git (Apr 23 2011 09:51:43)
Features compiled in: Vorbis FLAC MP3 RGB zLib Theora

On moving the mouse to the top of the window/screen an icon bar will pop up
A crash follows here unfortunately with the console message

WARNING: PicButtonWidget has size 40x40, but a surface with 40x40 is to be set!

Crashlog attached

Hugo 2: Whodunit? (DOS/English)

AmigaOS4 - PPC - SDL - BE
gcc (GCC) 4.2.4 (adtools build 20090118)

[Anonymous]

Crashlog Icon Bar crash

[digitall]

Can't replicate on Linux x86_32 with:
ScummVM 1.3.0git4573-g9b47a42-dirty (Apr 24 2011 17:06:30)
Features compiled in: Vorbis FLAC MP3 ALSA SEQ TiMidity RGB zLib FluidSynth Theora

But there is a valgrind error here:
==21556== Invalid read of size 1
==21556== at 0x808794D: Hugo::FileManager::saveGame(short, Common::String con
st&) (file.cpp:404)
==21556== by 0x8060526: Hugo::HugoEngine::run() (hugo.cpp:268)
==21556== by 0x804F34B: runGame(PluginSubclass<MetaEngine> const*, OSystem&,
Common::String const&) (main.cpp:208)
==21556== by 0x804FF9D: scummvm_main (main.cpp:421)
==21556== by 0x804E33E: main (posix-main.cpp:48)
==21556== Address 0x65077e6 is 0 bytes after a block of size 86 alloc'd
==21556== at 0x4025EEE: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-l
inux.so)
==21556== by 0x8060FB3: Hugo::HugoEngine::loadHugoDat() (hugo.cpp:466)
==21556== by 0x80603C7: Hugo::HugoEngine::run() (hugo.cpp:244)
==21556== by 0x804F34B: runGame(PluginSubclass<MetaEngine> const*, OSystem&, Common::String const&) (main.cpp:208)
==21556== by 0x804FF9D: scummvm_main (main.cpp:421)
==21556== by 0x804E33E: main (posix-main.cpp:48)

[digitall]

raziel_ : Strangerke has fixed a number of valgrind issues. Please could you confirm if this bug is still occuring in the latest Git?

[Anonymous]

revision de5ec74

Fixed

A warning though: All former savegames crash on loading! (at least for me)

[Strangerke]

Sorry for your savegames... several unsafe use of read() and write() were fixed, but they broke the savegames made on BE systems. I can't do much about that :/