ScummVM / Bugs / #5386 AGI LSL1: TAB stops working after restart

#5386 AGI LSL1: TAB stops working after restart

Milestone: AGI: Leisure Suit Larry 1

Status: closed-fixed

Owner: Filippos Karapetis

Labels: Verbs/Inventory (104)

Priority: 7

Updated: 2011-09-25

Created: 2010-09-24

Creator: Torbjörn Andersson

Private: No

Current 1.2.0 branch
English version of the game (1.00 1987-06-01, 5.25"/3.5"/DOS/English, according to the detector)

This one's easy to reproduce: Start the game, andswer the questions, and type "restart" (or walk into a dark alley and let the game restart on its own). The TAB key no longer brings up the inventory. It seems the "game controllers" are reset on restart, but this game never recreates them. (I tried Space Quest 2, and the bug didn't happen there.)

Discussion

Torbjörn Andersson - 2010-09-24

I forgot to mention: The bug does not happen with the original interpreter in DOSBox.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Torbjörn Andersson - 2010-09-28

This bug does not seem to happen in NAGI. (http://github.com/sonneveld/nagi)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Torbjörn Andersson - 2010-09-30

Unlike ScummVM, NAGI doesn't appear to ever clear the controllers list, except in nagi_init(), which appears to only be called once. If cmd_set_key() fails to find a free slot, it just silently ignores it.

ScummVM's cmd_set_key() also ignores attempts to overflow the list, but prints a warning.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Torbjörn Andersson - 2010-10-01

Possible patch against 1.2.0 branch

agi-controllers.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Torbjörn Andersson - 2010-10-01

Assuming I understood the problem correctly, the patch I just attached should fix the problem. It doesn't work exactly like how I think NAGI works, but...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eugene Sandulenko - 2011-04-17

priority: 5 --> 7

assigned_to: nobody --> sev
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eugene Sandulenko - 2011-04-17

I'll review the patch.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Torbjörn Andersson - 2011-06-10

Any news about this?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Filippos Karapetis - 2011-09-25

Fixed in r81fdf2c, by applying eriktorbjorn's patch and checking against NAGI

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Filippos Karapetis - 2011-09-25

assigned_to: sev --> thebluegr

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

AGI LSL1: TAB stops working after restart

A cross-platform interpreter for many point-and-click adventure games

Group

Searches

Help

#5386 AGI LSL1: TAB stops working after restart

Discussion