#3252 PALM: Elvira 1/2 crashes after game screen is rendered

[chrilith]

Hi,

This problem occured with Elvira I and II right after the game screen is rendered. System report "Non-Word-aligned handle", so it should be an aligment problem.

I have attached a -d5 output.
Version 0.11.0svn (2007-06-16)
Elvira I and II AtariST/French/Floppy

Thanks
Chris

[chrilith]

PalmOS debug log (-d5)

[kirben]

Logged In: YES
user_id=34715
Originator: NO

What exactly is the meaning of that error message? what should I be look for, code wise?

[Max Horn]

Logged In: YES
user_id=12935
Originator: NO

A non-word-aligbned error would happen if 16 or 32 bit of data are read in one go, from a non-aligned address. So on targets where this is a problem, we #define SCUMM_NEED_ALIGNMENT, which in turn causes safe code to be used for functions like READ_UINT32 etc. -- safe here means that these funcs then read the data bytewise (which is slower, hence we don't always do it).

So, essentially anything that tries to directly read 16 or 32 bit of data from a memory block which is not guaranteed to be memory aligned could trigger the problem.

[kirben]

Logged In: YES
user_id=34715
Originator: NO

There was alignment issues in vc45_setWindowPalette() code, but that would only effect Elvira 2 and Waxworks.

The debug levels in the AGOS engine, set a different type of output. The output of debug level 2 (Script opcodes) and 3 (Video opcodes) would be more useful.

[Max Horn]

Logged In: YES
user_id=12935
Originator: NO

Chris, it would be *really* helpful if you could provide some extra info.

[chrilith]

-d2 Elvira 1 / -d3 Elvira 2

[chrilith]

Logged In: YES
user_id=637029
Originator: YES

Here are the requested outputs. Sorry for the delay.
File Added: logs.zip

[kirben]

Logged In: YES
user_id=34715
Originator: NO

Looking at the logs, I suspect the icon decoding code is causing the error. Since you are using AtariST versions of Elvira 1/2, the decompressIconPlanar() function of engines/agos/icons.cpp is been used.

Try adding 'return;' at start of AGOSEngine_Elvira1::drawIcon() and AGOSEngine_Elvira2::drawIcon() functions in engines/agos/icons.cpp, to see if disabling icon decoding prevents the errors.

[chrilith]

Logged In: YES
user_id=637029
Originator: YES

I commited a strange workaround for this bug. I've tested many other things but none seems to fix the problem excepted this amazing printf. I reduce the priority for now and keep it open because this is, of course, not the good way to fix this bug...

[chrilith]

Logged In: YES
user_id=637029
Originator: YES

Compiler is unbale to optimize properly this piece of code. I changed compiler options and it fixes the problem.
We can close this bug since it is due to compiler.