#2481 SCUMM: indy3 VGA not recognized

[Charles E. Reno]

I am using the latest Daily Snapshot of ScummVM and
while I am certain that this game worked fine on the
0.8.0 release, none of the recent dailies have detected
it. When I attempt to add it to the "games" listing,
ScummVM responds that it could not find a valid game.
I did check the MD5 and it matches the official one
listed on the MD5 database. If I manually edit the
"scummmvm.ini" file and add the game to the list, it
plays just fine.

[Torbjörn Andersson]

Logged In: YES
user_id=577918

Strange. My English Indy 3 VGA is recognized by both ScummVM
0.8.0 and 0.8.1.

[Charles E. Reno]

Logged In: YES
user_id=514082

Once again, I am using the latest Daily Snapshot. The 0.8.x
series works fine. The 0.9.0 CVS builds do not detect indy3
(Indiana Jones and the Last Crusade).

[Torbjörn Andersson]

Logged In: YES
user_id=577918

Sorry, I completely misread. Yeah, I can reproduce that.

[Torbjörn Andersson]

Logged In: YES
user_id=577918

As far as I can tell, when scanning for the game "indy3" it
correctly determines that looking for 00.lfl may be a good
idea. The file is found, and it enters the "buf[4] == '0' &&
buf[5] == 'R'" case, identifying the file as belonging to a
"newer V3 game".

Then it's rejected, because "indy3" is defined as having the
GF_OLD_BUNDLE flag.

Fingolfin, this looks like something you would know more
about than I do. Any ideas?

[Max Horn]

Logged In: YES
user_id=12935

<sigh> Yeah the problem here is that we now have reduced the number of
targets, so the version etc. info in the GameSettings struct is not anymore
accurate, nor are the feature flags. I'll take a look.

[kirben]

Logged In: YES
user_id=34715

Currently indy3 (FM-TOWNS/VGA), loom (FM-TOWNS) and zak (FM-
TOWNS) would be broken.

According to the cvs logs, this game detection code was
meant to help detect game, if md5 is disabled or md5 is not
known, but this code is before the md5 detection. Or was
the code added in this place for testing only?

Unfortunately this code was included in the last two
ScummVM releases too.

[Max Horn]

Logged In: YES
user_id=12935

Kirben, I thought the issue was specific to HEAD (which corresponds to what I
see here), so why is it unfortunate that the code was in 0.8.0 / 0.8.1 ?

Anyway, yeah, the current detection system is quite flawed. I have an improved
algorithm/system in my head in will soon either write it down or implement it,
shouldn't be too hard, mostly some rearranging / refactoring is needed.

[kirben]

Logged In: YES
user_id=34715

Yes, the bugs are specific to ScummVM 0.9.0 cvs.

This particular game detection code seems to be for testing
of future methods only though, so shouldn't have been left
in the release builds.

[Max Horn]

Logged In: YES
user_id=12935

See also <http://wiki.scummvm.org/index.php/Auto_detection>.

BTW, I think it's great that the code was so good that it managed to slip through
all our release testings, and didn't cause a single bug report since 0.8.0 :-).

[kirben]

Logged In: YES
user_id=34715

Closing, as I added fix to ScummVM cvs awhile ago, by just
removing the GF_OLD_BUNDLE check at that point.

Other general issues with game detection are better listed
under bug #1405794.