Menu ▾ ▴

#1854 FOTAQ: Crash when quitting through journal (MIDI-related)

Flight of the Amazon Queen
closed-fixed
Joost Peters
Unknown Crash/Other (1602)
5
2004-12-21
2004-12-20
Marco Hennig
No

I get an "Fatal signal: Segmentation Fault (SDL Parachute
Deployed)" message when using MT-32 music driver &
selecting "Give Up" in the journal screen or after
completing FOTAQ (Full English Talkie).

I first noticed this with the Dec 16 binary snapshot, but it
also happens with the latest snapshot as of now. (Dec
20)

Discussion

  • Marco Hennig

    Marco Hennig - 2004-12-20
    • summary: FOTAQ/MT-32: 'SDL Parachute Deployed' at completion/exit --> FOTAQ: 'SDL Parachute Deployed' at completion/exit (MT-32)
     

  • Max Horn

    Max Horn - 2004-12-20

    Logged In: YES
    user_id=12935

    KingGuppy, can you determine whether this is the fault of the MT32
    driver or rather a bug in FOTAQ?

     

  • Max Horn

    Max Horn - 2004-12-20
    • assigned_to: nobody --> kingguppy
    • summary: FOTAQ: 'SDL Parachute Deployed' at completion/exit (MT-32) --> FOTAQ: Crash at exit when using MT-32 driver
     

  • Jerome Fisher

    Jerome Fisher - 2004-12-20

    Logged In: YES
    user_id=717025

    This isn't related to the MT-32 emulator specifically.

    In MusicPlayer::~MusicPlayer() in queen/music.cpp:

    this->close();

    ends up setting _driver to 0, and the

    delete _parser;

    immediately after it eventually dereferences _driver through
    a (redundant) call to MidiParser::allNotesOff().

    There are several fixes possible, but I'd like someone who
    knows the code better to choose the right one.

     

  • Jerome Fisher

    Jerome Fisher - 2004-12-20
    • assigned_to: kingguppy --> nobody
     

  • Jerome Fisher

    Jerome Fisher - 2004-12-20
    • summary: FOTAQ: Crash at exit when using MT-32 driver --> FOTAQ: Crash when quitting through journal (MIDI-related)
     

  • Joost Peters

    Joost Peters - 2004-12-20

    Logged In: YES
    user_id=634621

    Someone who knows which code better? that of MidiDriver and the like,
    or the FOTAQ MusicPlayer?

     

  • Joost Peters

    Joost Peters - 2004-12-21

    Logged In: YES
    user_id=634621

    This is now fixed in CVS by reordering the of close()-ing
    and delete-ing of the _driver + _parser.

     

  • Joost Peters

    Joost Peters - 2004-12-21
    • assigned_to: nobody --> joostp
    • status: open --> closed-fixed