#1853 FOTAQ: 'WARNING: Trying to queue an invalid song number'

[Marco Hennig]

Hi devs,

When using the latest CVS binary (0.7.0 Dec 20 2004 23:
56:57) with FOTAQ (English Full Talkie), i get the
following warning at the end of the car chase sequence:

"WARNING: Trying to queue an invalid song number 176,
max 106!"

With the CVS binary from Dec 16, the message read:

"WARNING: Expected MThd or GMD header but found ':ä♦
ü' instead!"

[Marco Hennig]

savegame - car chase sequence

[Gregory Montoir]

Logged In: YES
user_id=230314

I just added this warning. The culprit is this entry in the
Sound::_tune array :

/* 39 - Truck Fanfare */
{ { 67, 177, 0 }, { 0, 0 }, 2, 0 },

Song number 177 is obviously wrong, as the max number is 106
for the fotaq CD version. Maybe a song number > 128 has a
special meaning ? Any idea on this Joost ?

[Joost Peters]

Logged In: YES
user_id=634621

IIRC only songs > 1000 are special commands.
All other should be interpreted as song numbers to be played.
I do remember something special about this fanfare, but
unfortunately my memory is failing me..
Quickly glancing at the original code raises more questions
than answers, so I'll have to think about this a bit.

[hp]

Logged In: YES
user_id=423368

I've just checked against original interpreter and scummvm 8
times in a row, and there is no difference in original behaviour
and scummvm... exept that joe says "oil be back" during the
crash sound in scummvm and after it in original.

if someone proves me wrong, I'll eat my sock ;)

now, stop hunting ghosts and do something useful
joostp... :P

[Joost Peters]

Logged In: YES
user_id=634621

I think what themmaster is trying to say is that the original interpreter
ignores this song and/or that there is no music missing.
So unless it is used to trigger a certain effect (that I'm unaware of). I
guess we should just keep our behaviour of ignoring it as well.

Will leave this open for a bit longer while I try to refresh my memory on
the subject and have confirmed this is indeed correct.

[Gregory Montoir]

Logged In: YES
user_id=230314

Yes, it's quite possible the song number was just invalid,
that wouldn't surprise me much... The original interpreter
has quite a few issues like that (OOB and the likes...).

[Joost Peters]

Logged In: YES
user_id=634621

There doesn't seem to by anything in the original code that
deals with this, and as there is no difference in behaviour
(missing music or some effect), I'm convinced this is just a
bug in the original.
I've changed the warning() in CVS to a debug(3, ...); and am
closing this.