Menu
▾
▴
scst-devel
|
From: Pascal de B. <p.d...@un...> - 2018-11-20 15:15:14
|
Hey,
Congrats on the 3.3.x release. Much appreciated.
As I'm adjusting to use the new 3.3.x codebase, I'm (re)noticing the following issue with generate-kernel-patch:
touch: cannot touch 'linux-4.9.137/drivers/scsi/qla2xxx/*': No such file or directory
mv: cannot stat 'linux-4.9.137/drivers/scsi/qla2xxx/*': No such file or directory
diff: qla2xxx-orig/4.9.137/Makefile: No such file or directory
And the resulting patch is broken. We used to work around this with a separate wrapper script.
When we manually place ~/software/downloads/linux-4.9.137.tar.xz there are no errors and the resulting patch seems fine, as in the kernel builds.
Something along these lines seems to resolve the issue, though I'm not sure if it's the correct approach:
--- ./scst-3.3.x-orig/scripts/generate-kernel-patch 2018-11-20 16:00:36.168956893 +0100
+++ ./scst-3.3.x/scripts/generate-kernel-patch 2018-11-20 15:59:17.628952224 +0100
@@ -257,6 +257,7 @@ if [ "${multiple_patches}" = "true" ]; t
fi
fi
+download_kernel "${kver}" || exit $?
####################
# Patch Generation #
Regards,
Pascal de Bruijn
Unilogic B.V.
|
|
From: Bart V. A. <bva...@ac...> - 2018-11-21 03:00:22
|
On 11/20/18 7:02 AM, Pascal de Bruijn wrote:
> As I'm adjusting to use the new 3.3.x codebase, I'm (re)noticing the
> following issue with generate-kernel-patch:
>
> touch: cannot touch 'linux-4.9.137/drivers/scsi/qla2xxx/*': No such file
> or directory
> mv: cannot stat 'linux-4.9.137/drivers/scsi/qla2xxx/*': No such file or
> directory
> diff: qla2xxx-orig/4.9.137/Makefile: No such file or directory
>
> And the resulting patch is broken. We used to work around this with a
> separate wrapper script.
>
> When we manually place ~/software/downloads/linux-4.9.137.tar.xz there
> are no errors and the resulting patch seems fine, as in the kernel builds.
>
> Something along these lines seems to resolve the issue, though I'm not
> sure if it's the correct approach:
>
> --- ./scst-3.3.x-orig/scripts/generate-kernel-patch 2018-11-20
> 16:00:36.168956893 +0100
> +++ ./scst-3.3.x/scripts/generate-kernel-patch 2018-11-20
> 15:59:17.628952224 +0100
> @@ -257,6 +257,7 @@ if [ "${multiple_patches}" = "true" ]; t
> fi
> fi
>
> +download_kernel "${kver}" || exit $?
>
> ####################
> # Patch Generation #
Hi Pascal,
This is not a regression but a longstanding issue. Anyway, thanks for
the patch. It has been applied on the 3.3 and trunk branches.
Bart.
|
|
From: Pascal de B. <p.d...@un...> - 2018-11-21 15:15:44
|
From: Bart Van Assche <bva...@ac...>
To: Pascal de Bruijn <p.d...@un...>, "scs...@li..." <scs...@li...>
Sent: 11/21/2018 4:00 AM
Subject: Re: [Scst-devel] generate-kernel-patch autodownload kernel tarball
On 11/20/18 7:02 AM, Pascal de Bruijn wrote:
> As I'm adjusting to use the new 3.3.x codebase, I'm (re)noticing the
> following issue with generate-kernel-patch:
snip snip
> Something along these lines seems to resolve the issue, though I'm not
> sure if it's the correct approach:
>
> --- ./scst-3.3.x-orig/scripts/generate-kernel-patch 2018-11-20
> 16:00:36.168956893 +0100
> +++ ./scst-3.3.x/scripts/generate-kernel-patch 2018-11-20
> 15:59:17.628952224 +0100
> @@ -257,6 +257,7 @@ if [ "${multiple_patches}" = "true" ]; t
> fi
> fi
>
> +download_kernel "${kver}" || exit $?
>
> ####################
> # Patch Generation #
Hi Pascal,
This is not a regression but a longstanding issue. Anyway, thanks for
the patch. It has been applied on the 3.3 and trunk branches.
Apparently I should have tested the patch better, as it's not quite right...
Specifically ${kver} should have been ${kver3} it seems...
Sorry about that :(
Regards,
Pascal de Bruijn
Unilogic B.V.
|
|
From: Pascal de B. <p.d...@un...> - 2018-11-22 09:17:20
|
From: Pascal de Bruijn <p.d...@un...>
To: Bart Van Assche <bva...@ac...>, "scs...@li..." <scs...@li...>
Sent: 11/21/2018 4:14 PM
Subject: Re: [Scst-devel] generate-kernel-patch autodownload kernel tarball
From: Bart Van Assche <bva...@ac...>
To: Pascal de Bruijn <p.d...@un...>, "scs...@li..." <scs...@li...>
Sent: 11/21/2018 4:00 AM
Subject: Re: [Scst-devel] generate-kernel-patch autodownload kernel tarball
On 11/20/18 7:02 AM, Pascal de Bruijn wrote:
> As I'm adjusting to use the new 3.3.x codebase, I'm (re)noticing the
> following issue with generate-kernel-patch:
snip snip
> Something along these lines seems to resolve the issue, though I'm not
> sure if it's the correct approach:
>
> --- ./scst-3.3.x-orig/scripts/generate-kernel-patch 2018-11-20
> 16:00:36.168956893 +0100
> +++ ./scst-3.3.x/scripts/generate-kernel-patch 2018-11-20
> 15:59:17.628952224 +0100
> @@ -257,6 +257,7 @@ if [ "${multiple_patches}" = "true" ]; t
> fi
> fi
>
> +download_kernel "${kver}" || exit $?
>
> ####################
> # Patch Generation #
Hi Pascal,
This is not a regression but a longstanding issue. Anyway, thanks for
the patch. It has been applied on the 3.3 and trunk branches.
Apparently I should have tested the patch better, as it's not quite right...
Specifically ${kver} should have been ${kver3} it seems...
Sorry about that :(
https://sourceforge.net/p/scst/svn/7825/
Please do cherrypick that into 3.3.x :)
Regards,
Pascal de Bruijn
Unilogic B.V.
|
|
From: Pascal de B. <p.d...@un...> - 2018-11-23 11:03:58
|
From: Pascal de Bruijn <p.d...@un...>
To: Bart Van Assche <bva...@ac...>, "scs...@li..." <scs...@li...>
Sent: 11/22/2018 10:16 AM
Subject: Re: [Scst-devel] generate-kernel-patch autodownload kernel tarball
From: Pascal de Bruijn <p.d...@un...>
To: Bart Van Assche <bva...@ac...>, "scs...@li..." <scs...@li...>
Sent: 11/21/2018 4:14 PM
Subject: Re: [Scst-devel] generate-kernel-patch autodownload kernel tarball
From: Bart Van Assche <bva...@ac...>
To: Pascal de Bruijn <p.d...@un...>, "scs...@li..." <scs...@li...>
Sent: 11/21/2018 4:00 AM
Subject: Re: [Scst-devel] generate-kernel-patch autodownload kernel tarball
Hi Pascal,
This is not a regression but a longstanding issue. Anyway, thanks for
the patch. It has been applied on the 3.3 and trunk branches.
Apparently I should have tested the patch better, as it's not quite right...
Specifically ${kver} should have been ${kver3} it seems...
Sorry about that :(
https://sourceforge.net/p/scst/svn/7825/
Please do cherrypick that into 3.3.x :)
Just to confirm...
We've generated a patch with 3.3.x svn (r7827) against linux-4.9.139, which compiled, and booted fine.
Our test machine is now running simple test workload, and so far it's doing fine.
Regards,
Pascal de Bruijn
Unilogic B.V.
|
|
From: Bart V. A. <bva...@ac...> - 2018-11-26 00:38:05
|
On 11/23/18 3:03 AM, Pascal de Bruijn wrote: > Just to confirm... > > We've generated a patch with 3.3.x svn (r7827) against linux-4.9.139, > which compiled, and booted fine. > > Our test machine is now running simple test workload, and so far it's > doing fine. Thanks for the testing and for having shared the test results :-) The 3.3.x tarball will be uploaded soon to the SourceForge website. Bart. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X