[Scst-svn] [master] qla2x00t-32gbit: Fix NULL vs IS_ERR() bug for debugfs_create_dir()

[Gleb C. <lna...@ya...>]

Commit: 6552b55
GitHub URL: https://github.com/SCST-project/scst/commit/6552b55c223d1599d19b2b8600f4823d4d2ad57b
Author: Gleb Chesnokov
Date: 2023-10-10T15:10:02+03:00
Log Message:
-----------
qla2x00t-32gbit: Fix NULL vs IS_ERR() bug for debugfs_create_dir()

Since both debugfs_create_dir() and debugfs_create_file() return ERR_PTR
and never NULL, use IS_ERR() instead of checking for NULL.

Fixes: 1e98fb0f9208 ("scsi: qla2xxx: Setup debugfs entries for remote ports")
Signed-off-by: Jinjie Ruan <rua...@hu...>
Link: https://lore.kernel.org/r/202...@hu...
Signed-off-by: Martin K. Petersen <mar...@or...>
[ commit d0b0822e32db upstream ]

Modified Paths:
--------------
 qla2x00t-32gbit/qla_dfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

===================================================================
diff --git a/qla2x00t-32gbit/qla_dfs.c b/qla2x00t-32gbit/qla_dfs.c
index 807fd7f..e0b55d2 100644
--- a/qla2x00t-32gbit/qla_dfs.c
+++ b/qla2x00t-32gbit/qla_dfs.c
@@ -120,7 +120,7 @@ qla2x00_dfs_create_rport(scsi_qla_host_t *vha, struct fc_port *fp)
 
 	sprintf(wwn, "pn-%016llx", wwn_to_u64(fp->port_name));
 	fp->dfs_rport_dir = debugfs_create_dir(wwn, vha->dfs_rport_root);
-	if (!fp->dfs_rport_dir)
+	if (IS_ERR(fp->dfs_rport_dir))
 		return;
 	if (NVME_TARGET(vha->hw, fp))
 		debugfs_create_file("dev_loss_tmo", 0600, fp->dfs_rport_dir,
@@ -712,14 +712,14 @@ create_nodes:
 	if (IS_QLA27XX(ha) || IS_QLA83XX(ha) || IS_QLA28XX(ha)) {
 		ha->tgt.dfs_naqp = debugfs_create_file("naqp",
 		    0400, ha->dfs_dir, vha, &dfs_naqp_ops);
-		if (!ha->tgt.dfs_naqp) {
+		if (IS_ERR(ha->tgt.dfs_naqp)) {
 			ql_log(ql_log_warn, vha, 0xd011,
 			       "Unable to create debugFS naqp node.\n");
 			goto out;
 		}
 	}
 	vha->dfs_rport_root = debugfs_create_dir("rports", ha->dfs_dir);
-	if (!vha->dfs_rport_root) {
+	if (IS_ERR(vha->dfs_rport_root)) {
 		ql_log(ql_log_warn, vha, 0xd012,
 		       "Unable to create debugFS rports node.\n");
 		goto out;