[Scst-svn] [master] scst_lib: Improve scst_put_acg()

[Gleb C. <lna...@ya...>]

Commit: c00af8a
GitHub URL: https://github.com/SCST-project/scst/commit/c00af8aab9d82d4b61dc466a38e373dd4132c244
Author: Gleb Chesnokov
Date: 2023-07-21T10:38:52+03:00
Log Message:
-----------
scst_lib: Improve scst_put_acg()

This patch refactors scst_put_acg() to directly call kref_put() with a
release callback that handles removal of scst_acg from the workqueue.
This replaces the previous approach of queuing a work item for each
kref_put() call, improving efficiency by reducing the number of queued
work items.

Modified Paths:
--------------
 scst/src/scst_lib.c | 45 +++++++--------
 1 file changed, 21 insertions(+), 24 deletions(-)

===================================================================
diff --git a/scst/src/scst_lib.c b/scst/src/scst_lib.c
index 208e58d..02d03ba 100644
--- a/scst/src/scst_lib.c
+++ b/scst/src/scst_lib.c
@@ -70,7 +70,6 @@
 static DEFINE_SPINLOCK(scst_global_stpg_list_lock);
 static LIST_HEAD(scst_global_stpg_list);
 
-static void scst_put_acg_work(struct work_struct *work);
 static void scst_free_acn(struct scst_acn *acn, bool reassign);
 
 struct scsi_io_context {
@@ -4826,49 +4825,47 @@ static void scst_free_acg(struct scst_acg *acg)
 	kobject_put(&tgt->tgt_kobj);
 }
 
-static void scst_release_acg(struct kref *kref)
-{
-	struct scst_acg *acg = container_of(kref, struct scst_acg, acg_kref);
-
-	scst_free_acg(acg);
-}
-
-struct scst_acg_put_work {
+struct scst_acg_release_work {
 	struct work_struct	work;
 	struct scst_acg		*acg;
 };
 
-static void scst_put_acg_work(struct work_struct *work)
+static void scst_release_acg_work(struct work_struct *work)
 {
-	struct scst_acg_put_work *put_work =
-		container_of(work, typeof(*put_work), work);
-	struct scst_acg *acg = put_work->acg;
+	struct scst_acg_release_work *release_work =
+		container_of(work, typeof(*release_work), work);
+	struct scst_acg *acg = release_work->acg;
 
-	kfree(put_work);
-	kref_put(&acg->acg_kref, scst_release_acg);
+	kfree(release_work);
+	scst_free_acg(acg);
 }
 
-void scst_put_acg(struct scst_acg *acg)
+static void scst_release_acg(struct kref *kref)
 {
-	struct scst_acg_put_work *put_work;
+	struct scst_acg *acg = container_of(kref, struct scst_acg, acg_kref);
+	struct scst_acg_release_work *release_work;
 	bool rc;
 
-	put_work = kmalloc(sizeof(*put_work), GFP_KERNEL | __GFP_NOFAIL);
-	if (WARN_ON_ONCE(!put_work)) {
-		kref_put(&acg->acg_kref, scst_release_acg);
+	release_work = kmalloc(sizeof(*release_work), GFP_KERNEL | __GFP_NOFAIL);
+	if (WARN_ON_ONCE(!release_work)) {
+		scst_free_acg(acg);
 		return;
 	}
 
-	INIT_WORK(&put_work->work, scst_put_acg_work);
-	put_work->acg = acg;
+	INIT_WORK(&release_work->work, scst_release_acg_work);
+	release_work->acg = acg;
 
 	/*
 	 * Schedule the kref_put() call instead of invoking it directly to
 	 * avoid deep recursion and a stack overflow.
 	 */
-	rc = queue_work(scst_release_acg_wq, &put_work->work);
+	rc = queue_work(scst_release_acg_wq, &release_work->work);
 	WARN_ON_ONCE(!rc);
-	return;
+}
+
+void scst_put_acg(struct scst_acg *acg)
+{
+	kref_put(&acg->acg_kref, scst_release_acg);
 }
 
 void scst_get_acg(struct scst_acg *acg)