[Scst-svn] [master] qla2x00t-32gbit: Pointer may be dereferenced

[Gleb C. <lna...@ya...>]

Commit: 1f107c7
GitHub URL: https://github.com/SCST-project/scst/commit/1f107c7ee56f9f4792e5ed56e16872282c23199b
Author: Gleb Chesnokov
Date: 2023-07-19T11:45:31+03:00
Log Message:
-----------
qla2x00t-32gbit: Pointer may be dereferenced

Klocwork tool reported pointer 'rport' returned from call to function
fc_bsg_to_rport() may be NULL and will be dereferenced.

Add a fix to validate rport before dereferencing.

Cc: st...@vg...
Signed-off-by: Shreyas Deodhar <sde...@ma...>
Signed-off-by: Nilesh Javali <nj...@ma...>
Link: https://lore.kernel.org/r/202...@ma...
Reviewed-by: Himanshu Madhani <him...@or...>
Signed-off-by: Martin K. Petersen <mar...@or...>
[ commit 00eca15319d9 upstream ]

Modified Paths:
--------------
 qla2x00t-32gbit/qla_bsg.c | 2 ++
 1 file changed, 2 insertions(+)

===================================================================
diff --git a/qla2x00t-32gbit/qla_bsg.c b/qla2x00t-32gbit/qla_bsg.c
index 25de9fb..cc8c98d 100644
--- a/qla2x00t-32gbit/qla_bsg.c
+++ b/qla2x00t-32gbit/qla_bsg.c
@@ -3000,6 +3000,8 @@ qla24xx_bsg_request(BSG_JOB_TYPE *bsg_job)
 
 	if (bsg_request->msgcode == FC_BSG_RPT_ELS) {
 		rport = fc_bsg_to_rport(bsg_job);
+		if (!rport)
+			return ret;
 		host = rport_to_shost(rport);
 		vha = shost_priv(host);
 	} else {