[Scst-svn] [master] qla2x00t-32gbit: Fix potential NULL pointer dereference

[Gleb C. <lna...@ya...>]

Commit: 0367c33
GitHub URL: https://github.com/SCST-project/scst/commit/0367c334c36aec8561218cfbab539160be993c66
Author: Gleb Chesnokov
Date: 2023-07-19T11:35:51+03:00
Log Message:
-----------
qla2x00t-32gbit: Fix potential NULL pointer dereference

Klocwork tool reported 'cur_dsd' may be dereferenced.  Add fix to validate
pointer before dereferencing the pointer.

Cc: st...@vg...
Signed-off-by: Bikash Hazarika <bha...@ma...>
Signed-off-by: Nilesh Javali <nj...@ma...>
Link: https://lore.kernel.org/r/202...@ma...
Reviewed-by: Himanshu Madhani <him...@or...>
Signed-off-by: Martin K. Petersen <mar...@or...>
[ commit 464ea494a40c upstream ]

Modified Paths:
--------------
 qla2x00t-32gbit/qla_iocb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

===================================================================
diff --git a/qla2x00t-32gbit/qla_iocb.c b/qla2x00t-32gbit/qla_iocb.c
index 2742d37..bdf505a 100644
--- a/qla2x00t-32gbit/qla_iocb.c
+++ b/qla2x00t-32gbit/qla_iocb.c
@@ -613,7 +613,8 @@ qla24xx_build_scsi_type_6_iocbs(srb_t *sp, struct cmd_type_6 *cmd_pkt,
 	put_unaligned_le32(COMMAND_TYPE_6, &cmd_pkt->entry_type);
 
 	/* No data transfer */
-	if (!scsi_bufflen(cmd) || cmd->sc_data_direction == DMA_NONE) {
+	if (!scsi_bufflen(cmd) || cmd->sc_data_direction == DMA_NONE ||
+	    tot_dsds == 0) {
 		cmd_pkt->byte_count = cpu_to_le32(0);
 		return 0;
 	}