Re: [Scst-devel] generate-kernel-patch autodownload kernel tarball

[Pascal de B. <p.d...@un...>]

From:   Pascal de Bruijn <p.d...@un...> 

 To:   Bart Van Assche <bva...@ac...>, "scs...@li..." <scs...@li...> 
 Sent:   11/21/2018 4:14 PM 
 Subject:   Re: [Scst-devel] generate-kernel-patch autodownload kernel tarball 

From:   Bart Van Assche <bva...@ac...> 

 To:   Pascal de Bruijn <p.d...@un...>, "scs...@li..." <scs...@li...> 
 Sent:   11/21/2018 4:00 AM 
 Subject:   Re: [Scst-devel] generate-kernel-patch autodownload kernel tarball 

On 11/20/18 7:02 AM, Pascal de Bruijn wrote: 
> As I'm adjusting to use the new 3.3.x codebase, I'm (re)noticing the  
> following issue with generate-kernel-patch: 


snip snip


> Something along these lines seems to resolve the issue, though I'm not  
> sure if it's the correct approach: 
>  
> --- ./scst-3.3.x-orig/scripts/generate-kernel-patch    2018-11-20  
> 16:00:36.168956893 +0100 
> +++ ./scst-3.3.x/scripts/generate-kernel-patch    2018-11-20  
> 15:59:17.628952224 +0100 
> @@ -257,6 +257,7 @@ if [ "${multiple_patches}" = "true" ]; t 
>     fi 
>   fi 
>  
> +download_kernel "${kver}" || exit $? 
>  
>   #################### 
>   # Patch Generation # 
 
Hi Pascal, 
 
This is not a regression but a longstanding issue. Anyway, thanks for  
the patch. It has been applied on the 3.3 and trunk branches. 




Apparently I should have tested the patch better, as it's not quite right...



Specifically ${kver} should have been ${kver3} it seems... 



Sorry about that :(


https://sourceforge.net/p/scst/svn/7825/



Please do cherrypick that into 3.3.x :)


Regards,


Pascal de Bruijn
Unilogic B.V.