[Scst-svn] SF.net SVN: scst: [303] trunk/scst/src/scst_targ.c

[<vl...@us...>]

Revision: 303
          http://scst.svn.sourceforge.net/scst/?rev=303&view=rev
Author:   vlnb
Date:     2008-03-14 03:42:03 -0700 (Fri, 14 Mar 2008)

Log Message:
-----------
Fixes possible *dev_cmd_count leak

Modified Paths:
--------------
    trunk/scst/src/scst_targ.c

Modified: trunk/scst/src/scst_targ.c
===================================================================
--- trunk/scst/src/scst_targ.c	2008-03-13 10:58:44 UTC (rev 302)
+++ trunk/scst/src/scst_targ.c	2008-03-14 10:42:03 UTC (rev 303)
@@ -2312,9 +2312,6 @@
 
 	TRACE_ENTRY();
 
-	atomic_dec(&cmd->tgt_dev->tgt_dev_cmd_count);
-	atomic_dec(&cmd->dev->dev_cmd_count);
-
 	rc = scst_done_cmd_check(cmd, &res);
 	if (rc)
 		goto out;
@@ -2505,7 +2502,10 @@
 	}
 #endif
 
-	if (cmd->tgt_dev != NULL) {
+	if (likely(cmd->tgt_dev != NULL)) {
+		atomic_dec(&cmd->tgt_dev->tgt_dev_cmd_count);
+		atomic_dec(&cmd->dev->dev_cmd_count);
+
 		if (unlikely(cmd->queue_type == SCST_CMD_QUEUE_HEAD_OF_QUEUE))
 			scst_on_hq_cmd_response(cmd);
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.